Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
c24afa2
feat(ui): add Home and Apps to the sidebar with a Generated Files gal…
PabloWiedemann Nov 10, 2026
e24e08e
feat(ui): open a generated file in a detail view and download it
PabloWiedemann Nov 10, 2026
2d1fbf0
feat(apps): run apps from a hosted Apps page on Comfy Cloud or this c…
vqt123 Nov 10, 2026
b7df8a6
apps: keep models loaded between app runs, and run the Apps build on …
vqt123 Nov 10, 2026
639d900
feat(apps): let an open app fill the Apps page
PabloWiedemann Nov 10, 2026
569fb3a
fix(ui): load Cloud assets once and use the design system's radio items
PabloWiedemann Nov 10, 2026
d64997c
Merge commit '569fb3a6' into fix/1993
PabloWiedemann Nov 10, 2026
a477615
fix(ui): keep the detail view on its file and clean up broken downloads
PabloWiedemann Nov 10, 2026
b47b977
Merge commit 'a4776154' into fix/1994
PabloWiedemann Nov 10, 2026
cf341bf
fix(apps): ignore COMFY_APPS_URL in packaged builds
PabloWiedemann Nov 10, 2026
88167b3
fix(ui): forget a detail file that is gone after a reload
PabloWiedemann Nov 10, 2026
a29190a
Merge branch 'fix/1993' into fix/1994
PabloWiedemann Nov 10, 2026
d6d437d
apps: the local queue tells each app its own runs, and two more model…
vqt123 Nov 10, 2026
bc689c4
apps: song uploads and the audio_encoders model folder
vqt123 Nov 10, 2026
4ac16e2
style(apps): format the upload name check in guards.ts
PabloWiedemann Nov 10, 2026
f92273f
Merge main and move Generated Files to its own Assets page
PabloWiedemann Nov 11, 2026
1562074
Merge the Assets page and keep only downloading a file
PabloWiedemann Nov 11, 2026
8b7daf3
Merge the Assets page and give Apps its own sidebar page
PabloWiedemann Nov 11, 2026
e020d3a
fix(ui): stop an asset download that stops sending data
PabloWiedemann Nov 11, 2026
6445c80
Merge branch 'PabloWiedemann/assets-detail-view' into PabloWiedemann/…
PabloWiedemann Nov 11, 2026
ffc533f
fix(apps): check for a destroyed apps view before reusing it
PabloWiedemann Nov 11, 2026
a5d5403
fix(ui): give each asset download its own partial file
PabloWiedemann Nov 12, 2026
6fdd847
fix(assets): harden asset listing and clear stale workspace assets
PabloWiedemann Nov 12, 2026
0cae754
fix(apps): address review on the hosted Apps page
PabloWiedemann Nov 12, 2026
8276507
Merge branch 'PabloWiedemann/sidebar-tabs-assets' into PabloWiedemann…
PabloWiedemann Nov 12, 2026
f98ee94
Merge branch 'PabloWiedemann/assets-detail-view' into PabloWiedemann/…
PabloWiedemann Nov 12, 2026
4b3b870
fix(apps): stream large Cloud results and wait for new jobs
PabloWiedemann Nov 12, 2026
ffa3846
fix(assets): read local assets from the output folders on disk
benceruleanlu Nov 13, 2026
aaf09b0
fix(assets): show the label on the Log in to Comfy Cloud button
benceruleanlu Nov 13, 2026
a470efd
Merge remote-tracking branch 'origin/main' into PabloWiedemann/sideba…
benceruleanlu Nov 13, 2026
3b75073
Merge remote-tracking branch 'origin/main' into HEAD
PabloWiedemann Nov 13, 2026
340b5d8
fix(assets): keep one page of Comfy Cloud assets
PabloWiedemann Nov 13, 2026
10baaee
fix(assets): show the original file when a thumbnail is slow
benceruleanlu Nov 13, 2026
b2d3f74
Merge PabloWiedemann/sidebar-tabs-assets into PabloWiedemann/assets-d…
PabloWiedemann Nov 13, 2026
735dc71
test(assets): make the slow-thumbnail test independent of runner spee…
benceruleanlu Nov 13, 2026
643165b
fix(assets): stop the download timer while the disk catches up
PabloWiedemann Nov 13, 2026
b4a1890
fix(assets): refuse storage redirects and remember the folder after a…
PabloWiedemann Nov 13, 2026
e5c95e9
fix(assets): open the save dialog over the window that holds the Asse…
PabloWiedemann Nov 13, 2026
ef08019
Merge PabloWiedemann/assets-detail-view into PabloWiedemann/apps-host…
PabloWiedemann Nov 13, 2026
caa9d80
fix(apps): remove a half-written result when saving it fails
PabloWiedemann Nov 13, 2026
eb72f31
fix(apps): grant Apps permissions only to the Apps origin
PabloWiedemann Nov 13, 2026
9f91883
fix(apps): say why Comfy Cloud did not open instead of asking to add it
PabloWiedemann Nov 13, 2026
5cdaae5
Merge review fixes into PabloWiedemann/sidebar-tabs-assets
PabloWiedemann Nov 13, 2026
24203c6
Merge PabloWiedemann/sidebar-tabs-assets into PabloWiedemann/assets-d…
PabloWiedemann Nov 13, 2026
c65a9f2
Merge PabloWiedemann/assets-detail-view into PabloWiedemann/apps-host…
PabloWiedemann Nov 13, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,5 @@ docs/telemetry.md
__pycache__/
*.pyc
coverage/

.apps-url
52 changes: 52 additions & 0 deletions e2e/assets.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import { copyFile, mkdir, mkdtemp, rm } from 'node:fs/promises'
import os from 'node:os'
import path from 'node:path'
import { test, expect } from '@playwright/test'
import { launchApp, type AppContext } from './launchApp'

const SIDEBAR_ASSETS = '[data-testid="app-sidebar-assets"]'
const ASSETS_GRID = '[data-testid="assets-grid"]'
const SAMPLE_IMAGE = path.resolve('src/renderer/src/assets/sidebar/hills-sunset.jpg')

let ctx: AppContext
let outputDir: string

test.describe.configure({ mode: 'serial' })

test.beforeAll(async () => {
outputDir = await mkdtemp(path.join(os.tmpdir(), 'comfy-assets-output-'))
await mkdir(path.join(outputDir, 'landscapes'), { recursive: true })
await copyFile(SAMPLE_IMAGE, path.join(outputDir, 'landscapes', 'ComfyUI_00001_.jpg'))
ctx = await launchApp(
{ settings: { firstUseCompleted: true, telemetryEnabled: false, outputDir } },
{ stayOnHome: true }
)
})

test.afterAll(async () => {
await ctx.cleanup()
await rm(outputDir, { recursive: true, force: true })
})

test('Assets shows the images in the output folder with no build running and no login @windows @macos @linux', async () => {
expect(await ctx.panel.click(SIDEBAR_ASSETS)).toBe(true)

await ctx.panel.waitForVisible(ASSETS_GRID)
await expect
.poll(
() =>
ctx.panel.evaluate<boolean>(
`(() => {
const img = document.querySelector('${ASSETS_GRID} img')
return !!img && img.complete && img.naturalWidth > 0
})()`
),
{ message: 'the first image from disk loads', timeout: 20_000 }
)
.toBe(true)
const src = await ctx.panel.evaluate<string>(
`document.querySelector('${ASSETS_GRID} img').getAttribute('src')`
)
expect(src.startsWith('comfy-output://file/')).toBe(true)
expect(decodeURIComponent(src)).toContain('ComfyUI_00001_.jpg')
})
3 changes: 2 additions & 1 deletion electron.vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ export default defineConfig({
comfyTitleBarPreload: resolve(__dirname, 'src/preload/comfyTitleBarPreload.ts'),
comfyTitlePopupPreload: resolve(__dirname, 'src/preload/comfyTitlePopupPreload.ts'),
comfyTitleTooltipPreload: resolve(__dirname, 'src/preload/comfyTitleTooltipPreload.ts'),
comfySystemModalPreload: resolve(__dirname, 'src/preload/comfySystemModalPreload.ts')
comfySystemModalPreload: resolve(__dirname, 'src/preload/comfySystemModalPreload.ts'),
appsPreload: resolve(__dirname, 'src/preload/appsPreload.ts')
}
}
}
Expand Down
42 changes: 42 additions & 0 deletions locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
"builds": "Builds",
"navigation": "Navigation",
"home": "Home",
"apps": "Apps",
"assets": "Assets",
"collapse": "Collapse sidebar",
"expand": "Expand sidebar",
"signInTitle": "Log in to Comfy",
Expand All @@ -30,6 +32,46 @@
"crashedWithSignal": "Crashed ({signal})",
"failedToStartReason": "Failed to start: {reason}"
},
"assets": {
"kindLabel": "Asset type",
"kind": {
"all": "All",
"image": "Images",
"video": "Videos",
"3d": "3D",
"audio": "Audio"
},
"refresh": "Refresh assets",
"search": "Search by name...",
"viewOptions": "View options",
"layoutLabel": "Layout",
"layout": {
"masonry": "Masonry",
"grid": "Grid"
},
"sortLabel": "Sort by",
"sort": {
"newest": "Newest first",
"oldest": "Oldest first"
},
"showLabel": "Show",
"showName": "File name",
"showDetails": "File details",
"emptyTitle": "No assets yet",
"emptyBody": "Open an app to make assets.",
"loadFailed": "Couldn't load assets",
"download": "Download",
"downloadFailed": "Couldn't download asset",
"noMatches": "No matching assets",
"noMatchesHint": "Try another type or search.",
"filter": "Filter",
"signedOutTitle": "Log in to see your assets",
"signedOutBody": "Assets that you make in Comfy Cloud show here.",
"signIn": "Log in to Comfy Cloud"
},
"apps": {
"loadFailed": "The apps page at {url} could not load."
},
"home": {
"title": "Welcome. Let's create!",
"openComfyUI": "Open ComfyUI",
Expand Down
42 changes: 42 additions & 0 deletions locales/zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
"builds": "构建",
"navigation": "导航",
"home": "主页",
"apps": "应用",
"assets": "资产",
"collapse": "收起侧边栏",
"expand": "展开侧边栏",
"signInTitle": "登录 Comfy",
Expand All @@ -30,6 +32,46 @@
"crashedWithSignal": "已崩溃({signal})",
"failedToStartReason": "启动失败:{reason}"
},
"assets": {
"kindLabel": "资产类型",
"kind": {
"all": "全部",
"image": "图片",
"video": "视频",
"3d": "3D",
"audio": "音频"
},
"refresh": "刷新资产",
"search": "按名称搜索...",
"viewOptions": "视图选项",
"layoutLabel": "布局",
"layout": {
"masonry": "瀑布流",
"grid": "网格"
},
"sortLabel": "排序方式",
"sort": {
"newest": "最新优先",
"oldest": "最早优先"
},
"showLabel": "显示",
"showName": "文件名",
"showDetails": "文件详情",
"emptyTitle": "暂无资产",
"emptyBody": "打开一个应用来生成资产。",
"loadFailed": "无法加载资产",
"download": "下载",
"downloadFailed": "无法下载资产",
"noMatches": "没有匹配的资产",
"noMatchesHint": "试试其他类型或搜索词。",
"filter": "筛选",
"signedOutTitle": "登录以查看你的资产",
"signedOutBody": "你在 Comfy Cloud 中生成的资产会显示在这里。",
"signIn": "登录 Comfy Cloud"
},
"apps": {
"loadFailed": "无法加载应用页面:{url}"
},
"home": {
"title": "欢迎。开始创作吧!",
"openComfyUI": "打开 ComfyUI",
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"dev:bootstrap": "node -e \"process.env.COMFY_FORCE_BOOTSTRAP_GIT='1';require('child_process').execSync('electron-vite dev',{stdio:'inherit',env:process.env})\"",
"build": "pnpm run typecheck && electron-vite build",
"start": "electron-vite preview",
"apps": "node scripts/apps.mjs",
"postinstall": "node ./scripts/postinstall.mjs",
"todesktop:beforeInstall": "./scripts/todesktop-beforeInstall.cjs",
"todesktop:beforeBuild": "./scripts/todesktop-beforeBuild.cjs",
Expand Down
41 changes: 41 additions & 0 deletions scripts/apps.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#!/usr/bin/env node
import { spawn, spawnSync } from 'node:child_process'
import { readFileSync } from 'node:fs'
import { createRequire } from 'node:module'
import path from 'node:path'
import { fileURLToPath } from 'node:url'

const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..')
const require = createRequire(import.meta.url)

function urlFromFile() {
try {
return readFileSync(path.join(root, '.apps-url'), 'utf8').trim()
} catch {
return ''
}
}

const appsUrl = process.env.COMFY_APPS_URL || urlFromFile()
const env = appsUrl ? { ...process.env, COMFY_APPS_URL: appsUrl } : { ...process.env }

const electronVite = path.join(
path.dirname(require.resolve('electron-vite/package.json')),
'bin',
'electron-vite.js'
)
const build = spawnSync(process.execPath, [electronVite, 'build'], {
cwd: root,
stdio: 'inherit',
env
})
if (build.status !== 0) process.exit(build.status ?? 1)

console.log(
appsUrl
? `[apps] Apps page: ${appsUrl}`
: "[apps] No apps address set (COMFY_APPS_URL or a .apps-url file); using Desktop's built-in one."
)
const electron = require('electron')
const app = spawn(electron, ['.'], { cwd: root, stdio: 'inherit', env })
app.on('exit', (code, signal) => process.exit(code ?? (signal ? 1 : 0)))
Loading
Loading