Repository navigation
feat(ui): show builds as rows and list them in the sidebar - #1986
Closed
PabloWiedemann wants to merge 135 commits into
Closed
PabloWiedemann wants to merge 135 commits into
PabloWiedemann wants to merge 135 commits into
Conversation
…1948) Twenty-eight keys used in the settings, snapshots, storage, feedback and instance picker screens were never added to the locales. Each call passed inline English, so the UI looked right in English but those strings could not be translated. The keys now exist in en.json and zh.json with the same English text, and the call sites no longer carry an inline copy. The snapshots Export All button uses the existing snapshots.exportAllSnapshots key, which already had that text. The Comfy API announcement read announcement.comfyApi.highlights, which that announcement never defined, so its highlights list was always empty. The list is removed. localeCoverage.test.ts now fails when source code passes a literal key that en.json does not define, naming the file, line and key.
…es (#1949) Renderer tests built their own vue-i18n instances, most with handwritten dictionaries that had drifted from locales/en.json, so a test could pass on copy the app never shows. Every mount now relies on the instance vitest.setup.ts installs, and assertions use the production wording. The setup no longer hides duplicate-registration and missing-key warnings, so a reintroduced local instance shows up in test output.
Composables that call useI18n() outside a component are tested with
vi.mock('vue-i18n'). Each of the nine mocks invented its own t(): some
echoed the key, some echoed the inline fallback text, some formatted
params into the key. None showed what a user reads, and the fallback
echoes would keep passing on copy that has drifted from en.json.
vueI18nWithAppMessages builds the mock from the real vue-i18n with the
same options as createAppI18n, now shared through i18nOptions.ts, so
these tests assert the production English. useActionGuard and
useListAction set window.api instead of replacing window, because real
translation needs window.performance.
213 translation calls in the renderer passed an inline English default alongside a key that en.json already defines. The renderer bundles en.json, so those defaults never rendered, but they were a second copy of the copy: 20 had already drifted, for example "Delete" where the app says "Uninstall" and "Browse" where it says "Browse…". The calls now pass only the key. localeCoverage.test.ts now fails when a translation call passes inline text, naming the file, line and key.
…arts (#1954) ComfyUISettingsContent.test.ts and InstancePickerView.test.ts imported their component inside the mount helper, so the first test paid to compile it. On CI that took up to 3.8 s of the 5 s per-test limit, and the first ComfyUISettingsContent test timed out at 5,082 ms on #1949. Import both components at the top of the file so Vitest loads them while collecting the file. Locally the first tests drop from 1,267 ms and 2,217 ms to 54 ms and 35 ms.
One-time cleanup of comments in Python, shell, PowerShell, NSIS, Swift, CSS, HTML, Vue style blocks, and workflow YAML. AGENTS.md keeps new ones out from here. Kept: shebangs, PowerShell Get-Help blocks, and the version comments after pinned action SHAs. The reset scripts printed their header comment as --help, so that text moved into a usage() function (bash) and a Get-Help block (reset-windows.ps1). Vue style exception fingerprints are regenerated for blocks that lost a comment. Co-authored-by: Claude <noreply@anthropic.com>
…1955) Rename the remaining instance copy from the Milestone 1 QA thread, in English and Chinese: - Add Existing Instance becomes Add Existing Build, its subtitle reads Add an existing ComfyUI install to Comfy Desktop, and Track Install becomes Add Build. - The Restore From Snapshot page names the source and the new install as builds. - Duplicate Instance becomes Duplicate, with a Duplicate Build dialog. - Create Build becomes Upload Build, with the hint Upload this build to Comfy Developer Platform.
* fix(settings): scope builds to their workspace and update naming * test(e2e): use the renamed last-used build option * fix(settings): keep requested and host builds in the scoped picker Keep the host build visible when Hide Cloud is on, so opening settings from a cloud build window still selects it and keeps its auto action. Refresh the picker cache before resolving a requested build that is not cached yet, so a deep link or a just-copied build is not rejected. When the modal is opened for a specific build from the dashboard, scope it to that build's workspace until the saved dashboard workspace changes, so a pending or failed settings write cannot hide it. Share the workspace membership check between the dashboard and the main process, and scope the picker once per caller so the snapshot builder forwards the scoped list and selection verbatim. * fix(settings): use build naming in the Update and Snapshots tabs Rename the remaining instance copy shown inside the settings modal: the update undo hint, copy-and-update and release-update prompts, and the snapshot delete, restore and import confirmations, in English and Chinese.
* docs: delete TESTING.md and e2e/README.md Most of both files restated package.json scripts, the Vitest and Playwright configs, and the CI workflows, and the e2e spec inventory had drifted (19 of 59 specs missing). Drop the README links to them. * docs: delete the #926 handoff note and trim README Drop the README sections that restated package.json scripts, the source tree, and the release workflow files.
* fix: rename installation heading to Install a New Build * fix: use build terminology in installation labels
What's New was a value of activePanel, so opening it replaced the page and closing it could only reset to 'comfy', which is the dashboard in a window with no install. A performance test kept running with its page gone from view. Over a page, What's New now opens as a modal without changing activePanel, so closing has nothing to restore. Over the live canvas it still uses the 'announcement' key, because that is what brings the panel view up above the canvas, and closing undoes only that. The open path moves focus itself because setActivePanel no longer runs there: the bell click leaves focus in the title bar, and Escape has to reach the modal. Main decides what closing does because the renderer's activePanel doesn't follow file-menu wizards, and resetting would have dropped a wizard opened under the modal.
… tests from happy-dom (#1969) * test: run main, preload, and shared tests in Node The unit config ran everything under happy-dom unless a file opted out, so 151 main-process test files ran against a fake DOM that production never has. Split it into a node project and a renderer project, and drop the 50 per-file node directives that split makes redundant. Vitest's web transform for DOM environments is also what stopped vi.mock of Node builtins from loading on Windows. agentRequirementsLaunch, pip, and buildLaunchEnv now load there. comfyContentScript and comfyTerminalContentScript evaluate scripts injected into a page, so they stay on happy-dom through a file directive. csp and localeCoverage read the filesystem, so they move to the node project. * test: make renderer tests independent of happy-dom These tests relied on things only a simulated DOM allows, which blocks moving them to Vitest browser mode: - vitest.setup.ts imported vue-i18n before a test's vi.mock could register. Install the plugin in beforeAll, after the test file is collected. - Tests replaced window, which a real browser forbids. Add stubWindowApi, which stubs window.api and rejects keys ElectronApi doesn't declare. - Drag and pointer tests passed plain objects as event data. Use a real DataTransfer and a real PointerEvent. - useFirstUseChain's telemetry mock omitted a re-export that a real ES module link requires. All 112 renderer test files (1,670 tests) pass under both happy-dom and real Chromium with a throwaway browser-mode config. happy-dom stays the configured environment for now. Switching is a separate change.
…1971) * test: run renderer tests in real Chromium with Vitest browser mode Renderer tests now run in headless Chromium through Vitest browser mode instead of happy-dom, so they exercise real layout, events, focus, and storage. happy-dom is removed. - The renderer project becomes `browser`. It also takes the two tests that evaluate injected page scripts, which were the last happy-dom users. The scripts are plain strings, so they need no Node. - Alias `vue` to the esm-bundler build in that project. The runtime-only build silently renders nothing for `template:` stubs. - Drop the fake localStorage from the setup file. Each Vitest session has its own browser context, so parallel files stay isolated, and the setup file clears storage after each test for files sharing a session. - Filter the one decodeEntities warning that Vue Test Utils string slots trigger. `onConsoleLog` is read from the root config, not per project. - CI installs headless Chromium in the Test job only. Locally, run `pnpm run test:browser:install` once per Playwright version. * fix(ci): patch Vitest browser advisories and pin Test to Ubuntu 24.04 Socket flagged critical advisories in @vitest/browser 4.0.18, which this branch introduces: GHSA-g8mr-85jm-7xhm, GHSA-p63j-vcc4-9vmv, and GHSA-2h32-95rg-cppp. Move vitest and @vitest/browser-playwright to 4.1.12, which has the fixes for all three, and update ws to a patched version in the lockfile because @vitest/browser depends on it. ubuntu-latest now resolves to 26.04, where Playwright 1.58.2 refuses to install Chromium. Pin only the job that needs a browser to ubuntu-24.04 rather than updating Playwright, which would also change the runner for the E2E and lifecycle suites. * test: run the node and browser projects one after the other Vitest gives the browser project its own pool, so running both projects together starts up to 16 workers instead of the 8 that happy-dom shared with Node. On a CI runner that pushed import time from 123s to 375s and made the node project time out while importing modules. Give each project a sequence.groupOrder so the browser project starts after the node project finishes. Capped to 4 cores locally, this cut transform time from 62s to 22s and import time from 168s to 85s, and the total run time did not get longer. Timeouts stay as they were, because raising them would hide the overload.
Follow-up to #1964, #1965 and #1966, which renamed these strings in English only. - zh: "新建实例" becomes "安装新构建" and the "environment" subtitle becomes "设置全新的 ComfyUI 安装。", using the 构建 and 安装 terms zh.json already uses. - en and zh: newInstall.grandSubtitle no longer says "instance". No code references this key today, so nothing changes on screen.
QA (Alexis) flagged that the install, add-existing and snapshot screens don't match the Builds page: they read as an old purple gradient gone black. Those screens layered a lighting band, a purple and teal wash, a purple glow and two beams. Mar's Figma and prototype specify one soft light from above with film grain, and have no beams or wash. - Takeovers use Mar's background: film grain, the setup frame's and ambient layer's radial gradients, and the oklch(0.16 0.003 285) base. - Benchmarks and Performance Tests share BrandBackground but sit beside Builds in the sidebar, so they use the exact Builds gradient. It now lives in one constant, so the two can't drift apart. - Remove the beams, wash, glow and vignette, plus the anchors and assets that existed only for them.
From Alexis's retest: the screen opened by the Load Snapshot menu item was titled "Restore From Snapshot", and its subtitle talked about recreating a build. - Title: "Restore From Snapshot" becomes "Load Snapshot", matching the menu items that open it. - Subtitle: "Load a saved snapshot file to recreate that build here." becomes "Load a snapshot file to install a build." - zh: 加载快照 and 加载快照文件以安装构建。, matching the existing 加载快照 menu items. The build menu's "Restore Snapshot" restores into an existing build, a different action, so it keeps its name.
…1975) * fix(ui): show the Read more link in info tooltips under Void The link was colored with --action, which Void sets to the foreground color, the same color as the tooltip bubble's background, so it rendered invisible and left what looked like extra height under the hint. Inherit the bubble's text color and underline it instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(ui): use Mar's dark tooltip bubble instead of the inverted one Mar's designs (Figma New-Home, Atoms/Tooltip) use a dark bubble: rgba(42,42,42,0.94) with a 10px backdrop blur, a 7% white border, an 8px radius, a 0 8px 12px shadow, 12px/16.2px medium text and no arrow. Void had inverted tooltips to a light bubble. Point the Void tooltip tokens at Mar's values, use them in the shared Tooltip, hide the arrow, and give the title-bar tooltip popup the same colors and metrics. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Clicking Update on a build tile used to open the build manager on its Update tab and fire the update from there, so the confirm appeared with the manager behind it. QA asked for the confirm to show on its own over the Builds page. The Builds page now loads the build's update action for its current channel and runs it through the same preflight the manager uses (busy guard, stop warning, pickers, confirm, disk-space check), then shows progress that returns to the Builds list. If no enabled update action is found, it falls back to opening the manager on the Update tab. The manager's preflight and progress setup move into useDetailActionPreflight so both surfaces share one copy. The title-bar pill and deep links keep opening the manager. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
main reverts the redesign (#1802, #1804, #1810) in #1892 to keep it off 1.1.9. Those commits predate the branch point, so merging main directly would apply the revert and silently drop the redesign from 24 files. main is merged here with #1892 reverted on top, so the redesign stays and every other main commit comes through. Conflict resolutions: - modelManifest.ts, builds.ts, versionCache.ts, firebaseAuthIdentity.ts, launch.ts, staffFlagTargeting.ts and its test: this branch only deleted comments in these files, so they take main's version with comments stripped by the no-comments rule. - BrandBackground.vue and its test: keep this branch's version. The redesign removed the beams that #1898 and #1930 kept from adding scroll range, so those fixes have nothing left to act on. Every file only one side changed matches that side exactly.
Builds page cards become single rows from the New Home frame: type icon, name, channel and version, an inline Update or error badge, a status column and one plain launch button such as Start on this computer or Open on Cloud. The sidebar lists every build under Builds. Clicking one launches it on the same path as the Builds page button. Clicking a card still opens its details page.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Clicking a build in the sidebar now opens its details page, switching to the Builds screen first when needed. Launching stays on the details page and on the Builds page buttons.
Rows use the solid card color, 6px badges, a 7px status dot with medium text, a 148px status column and a 240px action column, so status and buttons line up as in the frame. An errored build shows Stopped. The sidebar shows Builds as an uppercase group header that links to the Builds page, with the builds below it at 16px icons and 8px status dots. The collapsed sidebar keeps the Builds icon.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1976 (
bl/desktop-as-a-platform). Runs parallel to #1981, not on top of it.What changes
Builds page cards now follow the New Home frame (Figma 399:16754). Each build is one full-width row:
Stable · v0.20.1)⋯menu, now always visible, in a 240px right-aligned action columnSizes and colors come from the Figma variables mapped to theme tokens: solid
bg-card, 6px badges, a 7px status dot with medium text,subtle-foregroundfor the Stopped dot andsuccessfor Running.Clicking a card (once or twice) still opens its details page, as before. The button launches.
Sidebar: Builds becomes an uppercase group header, as in the frame. It still links to the Builds page and is highlighted there. Every build is listed below it with a 16px type icon and an 8px green dot when it runs (red on error). The collapsed sidebar keeps the plain Builds icon. Clicking a build opens its details page (
openBuildDetails→BuildDetailsView), switching to the Builds screen first when you are on Performance Tests or Benchmarks. It does not launch. Launching stays on the details page and on the row buttons. The list hides when the sidebar is collapsed.Not added on purpose: the Figma's Remote tab, the split "Open on this computer ▾" button, the sidebar header's "+" button, the per-build counts in the sidebar, and the Locate / Retry install / Finish uninstall buttons.
Overlap with #1981
#1981 also edits
AppSidebar.vue,PanelApp.vueandChooserView.vue. This PR does not touchChooserView.vue. InAppSidebar.vueI leftmainRowsalone: the expanded sidebar filters the Builds row out ingroupsand renders the Builds header and the builds in their own block after the main rows, so #1981's Home and Apps rows stay above it. Expect small conflicts in the imports, theemitlist, and the<AppSidebar>props and the handler next toopenBuildDetailsinPanelApp.vue.Change breakdown
Total changed lines (added + deleted): 453.
src/renderer/src/views/chooser/ChooserInstallTile.vue,src/renderer/src/views/chooser/ChooserFamilyGrid.vue,src/renderer/src/panel/AppSidebar.vue,src/renderer/src/panel/PanelApp.vuelocales/en.json,locales/zh.jsonsrc/renderer/src/panel/AppSidebar.test.ts,src/renderer/src/panel/PanelApp.test.ts,src/renderer/src/views/ChooserView.test.tsMost of the product diff is the tile template rewrite. The script logic stays the same apart from the new labels and the Stopped status.
Tests
ChooserView.test.ts: assertions updated for the new labels, the Update available badge in the name row, and the Stopped status.AppSidebar.test.ts: new cases cover the builds list, the build click emittingopen-details, the running dot, and hiding the list when collapsed.PanelApp.test.ts: a new case clicks a sidebar build from the Benchmarks screen and checks that the details page opens and nothing launches.pnpm run typecheck,pnpm run lintandpnpm run format:checkpass.ChooserView,AppSidebar,PanelAppandBuildDetailsViewtests pass (153).agentUvReaper.test.tsandsessionActions/delegate.test.tsalso fail on the untouched base.get_design_contexton a row and on the sidebar Builds group), then rendered the rows and sidebar in headless Chromium with the app CSS to compare. An earlier dev app run showed the rows on real installs. I have not checked the sidebar's open-details change or the header in the live app, because only the feat(ui): add an Assets page to the sidebar with a generated files gallery #1981 dev app runs right now.