Repository navigation
fix(benchmarks): drop the Ideogram 4 int8 example removed upstream - #1737
Closed
benceruleanlu wants to merge 1 commit into
Closed
benceruleanlu wants to merge 1 commit into
benceruleanlu wants to merge 1 commit into
Conversation
Comfy-Org/workflow_templates#1338 removed benchmarks/image_ideogram4_t2i_int8.json from main, so the performance test page offers an example users can no longer download and the Benchmark templates check fails for every PR that touches its watched paths. Edited by hand rather than regenerated: regenerating from upstream main would also pull in the new gated Flux.3 Klein example, which needs the download support from the closed #1736.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
image_ideogram4_t2i_int8example fromassets/benchmark-templates.json.Why
Comfy-Org/workflow_templates#1338 (merged 2026-10-15 17:53 UTC) deleted
benchmarks/image_ideogram4_t2i_int8.jsonfrom itsmain. Desktop still offered that example on the performance test page, so picking it fails for users. The Benchmark templates / validate check catches this, but it only runs when its watched paths change, so main still lists the example. Every PR that touches the workflow file now fails, e.g. #1699 (run 38797982317):Behavior
The performance test page offers 11 examples instead of 12; image drops from 4 examples to 3. No code changes:
performanceTestExampleWorkflows.tsand its tests read the bundled list rather than fixed ids.The file is normally produced by
scripts/benchmark-templates.mjs. I edited it by hand instead of regenerating it, because a regeneration from upstreammainwould also add the new gatedimage_flux3_klein_distilled_t2iexample, which needs the download support from the closed #1736.Validation
node scripts/benchmark-templates.mjs validate: ✓ 11 examples, all downloadable from GitHub mainperformanceTestExampleWorkflows.test.tsChange breakdown
Total changed lines = additions + deletions (10). No merge-only changes.
Generated files (1)
assets/benchmark-templates.json(+0 / -10)