Repository navigation
fix: open MCP setup over the page like What's New and Feedback - #1724
benceruleanlu wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
MCP setup was the last overlay still modeled as a panel key, so it sat above What's New as a dialog and clicking the bell over it did nothing visible. It is now the third title-bar modal kind: one modal at a time, opening What's New replaces it, and it shares the page-cover layering, focus and Escape handling through BaseModal's `coversPage`. With no overlay panel keys left, a canvas overlay is just a running canvas with a modal open.
f64dbc6 to
e7e897e
Compare
MCP setup now opens like What's New and Send Feedback: as a modal over the canvas, in the same one-at-a-time slot. Clicking the What's New bell while MCP setup is open now replaces it, instead of opening What's New hidden underneath.
Stacked on #1719 (Send Feedback), which is stacked on #1712 (What's New).
Behavior
panelModal = 'mcp-setup') instead of a panel key. ComfyUI's MCP sidebar entry (desktop2-open-mcp-setup) opens it throughopenPanelModal. It's still limited to local installs, and the renderer receives it on the newcomfy-panel:open-mcp-setupchannel.McpSetupModalusesBaseModal'scoversPage, like Feedback. It sits below other dialogs, leaves an open dialog its focus, takes Escape before a wizard underneath, and closes through main's hide-then-dismiss round trip.isCanvasOverlayis just a running canvas with a modal open. Main and the renderer's transparency check both drop theirmcp-setupspecial case.comfy.desktop.view.openedwithview: 'mcp-setup'. Its owncomfy.desktop.mcp.*events are unchanged.Validation
src/main/lib/processIdentity.test.tsfailed once; it is the time-dependent test fixed onmainby test(processIdentity): fix same-second flake in readStartTimes real-process test #1721 and fix(process): read macOS lstart start times as UTC #1723, and this stack's base predates those fixes.covers-pagefromMcpSetupModalfails 5 of them.openPanelModal), the preload channel, and the swap from What's New inPanelApp.Change breakdown
209 changed lines (additions + deletions), relative to #1719:
src/main/host/panelView.ts,src/main/host/registry.ts,src/main/index.ts,src/main/popups/titlePopup.ts,src/preload/api.ts,src/renderer/src/composables/useMcpSetup.ts,src/renderer/src/panel/PanelApp.vue,src/renderer/src/panel/usePanelOverlays.ts,src/renderer/src/views/mcp/McpSetupModal.vue,src/shared/panelModal.ts,src/types/ipc.tssrc/main/host/panelView.test.ts,src/main/host/registry.test.ts,src/main/popups/titlePopup.test.ts,src/preload/api.test.ts,src/renderer/src/composables/usePageCoverModal.test.ts,src/renderer/src/panel/PanelApp.test.ts