Skip to content

test: fix updater and model staging CI failures - #1715

Merged
benceruleanlu merged 2 commits into
mainfrom
bl/fix-update-untracked-test
Oct 13, 2026
Merged

benceruleanlu merged 2 commits into
mainfrom
bl/fix-update-untracked-test

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Fix two CI test failures blocking main and #1712:

Validation: all 30 Python git-helper tests pass on Linux with Python 3.13. The three model-staging E2E tests pass ten consecutive Windows runs (30/30). Commit hooks check typecheck, lint, and formatting.

Change breakdown (11 total changed lines):

  • Product/source code: 1 file, src/main/lib/e2eHooks.ts (test-only E2E hook), +1/-2 lines, 27.3%.
  • Test code: 1 file, tests/python/test_update_comfyui.py, +4/-4 lines, 72.7%.
  • Documentation, configuration, generated files, lockfiles, vendored code: none.

@benceruleanlu
benceruleanlu requested review from a team as code owners October 13, 2026 06:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T06:37:00.555655Z d6f3d44 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2e6287ba-2789-4145-b693-be04b1d16d03
📥 Commits

Reviewing files that changed from the base of the PR and between d6f3d44 and 722702f.

📒 Files selected for processing (1)
  • src/main/lib/e2eHooks.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The update test now checks that an update preserves an untracked file. Model staging now initializes downloads before acquiring the model-root lock.

Changes: Update Test

Layer / File(s) Summary
Verify untracked file preservation
tests/python/test_update_comfyui.py
The test checks that the update reaches v2 and that notes.txt remains untracked with its contents preserved. Backup-branch assertions remain.

Model Staging

Layer / File(s) Summary
Initialize downloads before locking
src/main/lib/e2eHooks.ts
stageBuildModels initializes model downloads before acquiring the model-root lock. Existing result and error handling remain unchanged.

Priority: ⬆️ High

Merge Risk: ⚪ Minimal · up to 72270

The test and staging-order changes are ready to merge after normal checks.

### Architecture Summary

Architecture risk: 🔵 Low · up to 72270

The change affects 2 systems.

Changed systems: src, tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.
  • observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in tests/python/test_update_comfyui.py: The test is renamed to assert that an update preserves an untracked notes.txt, and now checks that the update reaches v2, the file remains untracked, and its contents are preserved. This replaces the prior expectation that the working tree becomes clean without the file; the subsequent backup-branch assertions remain.
  • observed — Modified behavior in src/main/lib/e2eHooks.ts: stageBuildModels now initializes model downloads before acquiring the model-root lock; the removed comment described the lock discipline but did not alter behavior.
Pre-merge checks · Passed 2
Passed Passed checks (2 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from synap5e October 13, 2026 06:36
@benceruleanlu benceruleanlu changed the title test: align updater test with preserved untracked files test: fix updater and model staging CI failures Oct 13, 2026
@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 98 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@comfy-greenlight-bot comfy-greenlight-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request at head commit 722702f has been reviewed and approved by Swarmhost's agentic review process.

The detailed evaluation is available to employees in the internal Slack review thread.

@benceruleanlu
benceruleanlu added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 6feee48 Oct 13, 2026
24 checks passed
@benceruleanlu
benceruleanlu deleted the bl/fix-update-untracked-test branch October 13, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants