Repository navigation
feat(telemetry): send app_version with ops-flag evaluation #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
48d7b37
feat(telemetry): send app_version with ops-flag evaluation
synap5e acfb402
test,docs: model SemVer prerelease ordering for version-gated ops flags
synap5e be7ac72
docs(telemetry): scope the version gate to live evaluation; note it i…
synap5e 6c7b78d
Merge remote-tracking branch 'origin/main' into synap5e/feat/ops-flag…
synap5e 710a011
Merge remote-tracking branch 'origin/main' into synap5e/feat/ops-flag…
synap5e 4d05936
docs(telemetry): note prerelease ordering and the dev-build version f…
synap5e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Low — For unpackaged builds
opts.appVersionisgit describeoutput (e.g.1.1.1-5-gabc1234or a bare commit SHA), which is local repo state rather than a shared release identifier. Sinceapp_versionis deliberately not consent-gated, that per-developer-machine string is sent to PostHog alongside the installation-stable id even when the user denied telemetry, which weakens the "every install of a release sends the same string" justification in the docblock above. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k2.7-code adversarial).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rejected: unpackaged builds only. Those are developers running from source, the value is a public-repo tag plus commit id with nothing personal in it, and sending it is what lets a developer exercise a version gate at all. Release builds send the shared release version.