Skip to content

Fix local auth popup error during system-browser sign-in - #1345

Closed
benceruleanlu wants to merge 2 commits into
mainfrom
agent/fix-local-auth-popup-error
Closed

benceruleanlu wants to merge 2 commits into
mainfrom
agent/fix-local-auth-popup-error

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Jul 30, 2026 •

Copy link
Copy Markdown
Member

Superseded by Comfy-Org/ComfyUI_frontend#14345.

The popup error is produced by the frontend auth error handler. The replacement handles Desktop's expected Firebase rejection at that source boundary instead of observing and removing rendered toast DOM. This Desktop injection approach is intentionally abandoned.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1d608e8b-5568-441c-b3e6-5fdc49f4783d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant