Skip to content
This repository was archived by the owner on Nov 2, 2018. It is now read-only.
This repository was archived by the owner on Nov 2, 2018. It is now read-only.

Non view.getType() solution for ViewPool #81

Description

@ypresto

Currently ViewPool uses view.getClass() so all root views should have different classes.
This does not good if you want to use view types with same layout, like RelativeLayout.

I found it silently does not reuse view if no matching type is registered.
https://github.com/Comcast/FreeFlow/blob/master/FreeFlow/src/com/comcast/freeflow/core/ViewPool.java#L38
This caused performance issue on our app for long time...

I think it is more convenient if it has interface similar to ListAdapter#getItemViewType(int).
SectionedAdapter#getItemViewType(FreeFlowItem) or view.getTag(FREE_FLOW_VIEW_TYPE) is also convenient.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions