Repository navigation
Make some curl options configurable to fix issue #19 - #22
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The configuration wiring and constructor updates are consistent, with no unresolved findings.
0 open findings
What changed in this PR
Makes outbound iTop cURL settings configurable through environment variables and enables TLS certificate verification by default, addressing issue #19.
Changes:
- Exposes connection timeout, request timeout, and certificate verification settings.
- Injects these settings into
iTopClient. - Updates existing tests for the expanded constructor.
| File | Description |
|---|---|
| tests/phpunit/iTopClientTest.php | Supplies the new constructor arguments. |
| src/Service/iTopClient.php | Applies injected cURL settings. |
| config/services.yaml | Wires environment settings into the client. |
| .env | Defines timeout defaults and enables certificate verification. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
This PR makes the following CURL options configurable (via your
.env.localconfiguration file):