Repository navigation
fix(mirror): keep python.org builds out of default locations - #305
Merged
Merged
Conversation
python.org's sources filled a version's default location (python/<version>/<platform>) whenever python-build-standalone had no build of it in that run. A sync skips anything already mirrored, so a release python.org shipped before python-build-standalone did, or one mirrored on a day the python-build-standalone listing failed, kept python.org's build as its default for good. python.org's builds now go only to the python.org location. For a version with no default build, the manifest generator already lists the python.org build as the default, and python-build-standalone's build takes over once it is mirrored. Defaults already mirrored from python.org (3.9.13, for example) are left as they are.
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #304. python.org's mirror sources (MSIs, arm64 NuGet packages and, since #304, install-manager zips) filled a version's default location,
python/<version>/<platform>, whenever python-build-standalone had no build of that version in the run.mirror-syncruns--sync-onlyand skips anything already mirrored, so that python.org build stayed the default for good in two cases:That breaks the intent of #304 that python-build-standalone stays the default and python.org's build is opt-in with
--signed. #304 made the window much wider by adding amd64 3.14+, where new releases land most often. It hasn't happened yet: every recent default (3.13.9–3.13.17, 3.14.x, 3.15.x) is python-build-standalone's.Type of Change
Related Issues
Relates to #304
Changes Made
python/<version>/python.org/<platform>.tar.gz(pythonOrgJobreplacespythonOrgJobs). The default location is python-build-standalone's alone.assembleManifestalready lists the python.org build as the default, and once python-build-standalone's build is mirrored it takes over, with python.org's as the alternate. A new test walks through that change.Testing
Test Environment
Test Steps
collectJobscases check that a python.org build never takes a default location, including when the python-build-standalone source fails.go run . --runtime python --dry-runagainst live upstream: 578 python-build-standalone jobs, plus 181 python.org jobs (99 from MSIs, 68 from NuGet, 14 from install-manager zips). All 181 targetpython/<version>/python.org/, and none target a default location.Test Results
golangci-lint: 0 issues../rnr checkfails only onTestGlobalVersion_NoConfigFileandTestGlobalVersion_RuntimeNotInConfigininternal/config, which fail the same way on unmodifiedmainon the machine I tested on. Nothing undersrc/changed.Checklist
golangci-lint runand fixed all issues (includes gofmt, govet, and 40+ linters)go mod tidyto clean up dependenciesgo test ./...) (apart from the twointernal/configtests above, unchanged frommain)Breaking Changes
N/A
Additional Notes
mirror-syncrun with feat(python): install python.org's signed Windows build with --signed #304's code. Without this fix it doesn't break anything today, because every default up to 3.15.2 is already mirrored, but the race stays open for the next release.generate-manifests-from-r2only runs after a successful sync. On such a day the manifests aren't regenerated.