Repository navigation
feat: add chromium adapter - #6
Open
aitorllj93 wants to merge 1 commit into
Open
aitorllj93 wants to merge 1 commit into
aitorllj93 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, this PR was vibe-coded; I've verified that it works on my machine and taken a look at the code, but I didn't write it myself.
I personally don't like the implementation; the debugger prompts for confirmation every time a command is run, and advanced commands require the extension to be installed and open—but as far as I know, it's the only way to make it work.
Feel free to reject it or suggest any possible changes or improvements, and I will do my best to incorporate them.