Skip to content

Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe#1422

Open
JohnRob-jnr wants to merge 3 commits into
CodeYourFuture:mainfrom
JohnRob-jnr:Wireframe2
Open

Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe#1422
JohnRob-jnr wants to merge 3 commits into
CodeYourFuture:mainfrom
JohnRob-jnr:Wireframe2

Conversation

@JohnRob-jnr
Copy link
Copy Markdown

@JohnRob-jnr JohnRob-jnr commented Jun 6, 2026 •
edited
Loading

Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Resubmitted my Wireframe as I made an error when working on it previously that would not allow it to be submitted for a pull request

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 6, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit f464a2a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a248c2681c5c700082355ad
😎 Deploy Preview https://deploy-preview-1422--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@JohnRob-jnr JohnRob-jnr added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@JohnRob-jnr JohnRob-jnr added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Core This is a core task and should be completed by all trainees labels Jun 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@JohnRob-jnr JohnRob-jnr added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
cjyuan
cjyuan reviewed Jun 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is error-free and page layout matches the wireframe well. Good job! It would probably match the wireframe better if all articles have the same padding space.

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

  • I noticed some typo. Could you run the page content through an AI tool to identify any potential improvements, even minor ones, to help ensure the content is fully polished?

Comment thread Wireframe/style.css
Comment on lines +97 to 106
section {
border: var(--line);
padding-bottom: var(--space);

text-align: left;
display: grid;
grid-template-columns: var(--space) 1fr var(--space);
> * {
grid-column: 2/3;
}
> img {
img {
width: 100%;
grid-column: span 3;
}
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jun 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

Could you look up the benefits of using a code formatter? I strongly recommend following this guide
to enable VS Code's "Format on Save" option or use its "Format Document" command. This will help ensure your code is consistently formatted and easier to read and maintain.

Comment thread Wireframe/index.html
Comment on lines +23 to +26
</article>
<section>
<img src="./img/readmeimg.png" alt="README File" />
<h3>README File</h3>
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jun 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Currently, the first item is an <article> while the other two are <section> elements. Since all three are standalone pieces of content with their own heading, description, image, and link, they should probably all be <article> elements.

  • Since all three topics are siblings, they should use the same heading level.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 7, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 7, 2026

Can you also restore the "Changelist" header in the PR description? It should be a level 2 header that looks like this:

Changelist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Core This is a core task and should be completed by all trainees Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohnRob-jnr @cjyuan