Skip to content

Cape Town | 2026-ITP-May | Juanita Nwachukwu | Sprint 2 | Wireframe to Web Code#1415

Open
Jay99-prog wants to merge 3 commits into
CodeYourFuture:mainfrom
Jay99-prog:feature/wireframe
Open

Cape Town | 2026-ITP-May | Juanita Nwachukwu | Sprint 2 | Wireframe to Web Code#1415
Jay99-prog wants to merge 3 commits into
CodeYourFuture:mainfrom
Jay99-prog:feature/wireframe

Conversation

@Jay99-prog
Copy link
Copy Markdown

@Jay99-prog Jay99-prog commented Jun 5, 2026

Juanita Nwachukwu | Sprint 2 | Wireframe to Web Code

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • I updated the webpage by replacing placeholder content with structured semantic HTML. I added three articles as required, each including an image, title, summary, and link. I improved accessibility by adding alt text to images and ensured the layout followed the wireframe requirements.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 5, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 942f993
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2562b713ad370008a1ea5d
😎 Deploy Preview https://deploy-preview-1415--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Jay99-prog Jay99-prog added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@Jay99-prog Jay99-prog added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jun 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

@Jay99-prog
Copy link
Copy Markdown
Author

Needs Review

@github-actions

This comment has been minimized.

@Jay99-prog Jay99-prog added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. labels Jun 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Jay99-prog Jay99-prog changed the title Cape Town | 2026-May | Juanita Nwachukwu | Sprint 2 - Wireframe to Web Code Cape Town | 2026-May | Juanita Nwachukwu | Sprint 2 | Wireframe to Web Code Jun 5, 2026
@Jay99-prog Jay99-prog changed the title Cape Town | 2026-May | Juanita Nwachukwu | Sprint 2 | Wireframe to Web Code Cape Town | 2026-ITP-May | Juanita Nwachukwu | Sprint 2 | Wireframe to Web Code Jun 5, 2026
@github-actions

This comment has been minimized.

@Jay99-prog Jay99-prog added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

@Jay99-prog Jay99-prog added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@Jay99-prog
Copy link
Copy Markdown
Author

Needs Review

@Jay99-prog Jay99-prog closed this Jun 5, 2026
@Jay99-prog Jay99-prog reopened this Jun 5, 2026
@Jay99-prog Jay99-prog added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 5, 2026

You need to delete the placeholder text, "Briefly explain your PR." from your PR description to pass the Validation Bot check.

Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You did a good job keeping your code error-free. However, the W3C Validator (https://validator.w3.org/) identifies a warning in your code. Could you revise your code to resolve this warning?

  • When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. To better align with the wireframe, here are a few areas where the layout and appearance could be refined:

    • The page title and the text beneath it should be centered.
    • Articles 2 and 3 should appear side by side beneath article 1, and the left and right edges of the article 1 should align with the left edge of the article 2 and the right edge of the article 3.
    • The footer content should be centered.

    Could you adjust the CSS to better match the wireframe's appearance and layout?


  • Current implementation does not yet meet this requirement:

    The articles section contains three distinct articles, each with its own unique image, title, summary, and link.

    The articles should have different images and their links should respectively point to the relevant resource.

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jun 5, 2026
@github-actions

This comment has been minimized.

@Jay99-prog Jay99-prog added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 6, 2026

No new commits on this branch on GitHub yet. If you had committed changes on your computer, you would also need to push (sync) the commits to GitHub.

Also, check if you have committed the changes to the correct branch.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@Jay99-prog Jay99-prog added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
Copy link
Copy Markdown
Author

@Jay99-prog Jay99-prog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates completed. Please review

Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The footer looks good.

  • According to W3C Validator (https://validator.w3.org/), there is an error and a warning in your code.

  • To better match the wireframe, can you update the CSS to ensure

    • The page title and the text beneath are centered on the page.
    • Articles 2 and 3 are placed side by side (horizontally) beneath article 1
  • There seems to be some "broken images" on the page.

Image

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@Jay99-prog Jay99-prog added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. labels Jun 6, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 7, 2026

I don't see any new commits pushed to GitHub yet.

Can you address the issues raised in the previous comment: #1415 (review) ?


Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 7, 2026
@Jay99-prog Jay99-prog removed the Submit:PR This work is submitted by creating a PR against CodeYourFuture's fork of this repo. label Jun 7, 2026
@Jay99-prog
Copy link
Copy Markdown
Author

Hi @cjyuan, thank you so much for taking time to review and provide feedback on my work.

While trying to workout my assesssment, I realised that there seems to be something wrong with the code on visual studio and I am not sure if this means that I might have to start from over. Please advise

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 7, 2026

You can continue fixing the code on this branch or "start all over" on this branch (or on a new branch and then open a new PR).

Comment thread Wireframe/index.html
</p>
=======
<p>This page explains README files, wireframes and Git branches.</p>
>>>>>>> de0ae2e6aca6abb5841f9c390a8f6a3e43ae3a91
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Jun 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a block of merged code from two conflicting sources. For example, one from the repo on GitHub and one from the local repo on your computer. It is easy to fix.

For each block of merged code, for example,

<<<<<<< HEAD
      <p>
        Code was provided and changed by Juanita Nwachukwu.
      </p>
=======
      <p>This page explains README files, wireframes and Git branches.</p>
>>>>>>> de0ae2e6aca6abb5841f9c390a8f6a3e43ae3a91

all you need to do is decide whether to keep the top part:

      <p>
        Code was provided and changed by Juanita Nwachukwu.
      </p>

or keep the bottom part:

      <p>This page explains README files, wireframes and Git branches.</p>

And then delete the part you do not want to keep, and delete the markers:
<<<<<<< HEAD
=======
>>>>>>> de0ae2e6aca6abb5841f9c390a8f6a3e43ae3a91

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new branch because the cod eon VS looked really damaged, and due to time contraints i made a new one with some updated and hopefully clean changes. The Validator didn't flag any errors, images where reuploaded and fixed, Please help me review it... this is the site:
#1423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants