Skip to content

London | 26-ITP-May | Talia Kucuk | Sprint 2 | Wireframe#1399

Open
TaliaKucuk wants to merge 12 commits into
CodeYourFuture:mainfrom
TaliaKucuk:feature/wireframe
Open

London | 26-ITP-May | Talia Kucuk | Sprint 2 | Wireframe#1399
TaliaKucuk wants to merge 12 commits into
CodeYourFuture:mainfrom
TaliaKucuk:feature/wireframe

Conversation

@TaliaKucuk
Copy link
Copy Markdown

@TaliaKucuk TaliaKucuk commented Jun 2, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This is my submission for the Sprint 2 Wireframe task.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 2, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit fc4d6c3
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a242ac9da76720008cfcbcb
😎 Deploy Preview https://deploy-preview-1399--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@TaliaKucuk TaliaKucuk added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@TaliaKucuk TaliaKucuk added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
cjyuan
cjyuan reviewed Jun 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is well formatted and error-free, and page layout match the wireframe well. Good job!

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

    • After you have made the footer fixed, please also ensure the footer and the article text content won't overlap.

  • Your PR description is missing a "Changelist section". See this guide for more info.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026
@TaliaKucuk
Copy link
Copy Markdown
Author

TaliaKucuk commented Jun 6, 2026

Code is well formatted and error-free, and page layout match the wireframe well. Good job!

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

    • After you have made the footer fixed, please also ensure the footer and the article text content won't overlap.

  • Your PR description is missing a "Changelist section". See this guide for more info.

@TaliaKucuk TaliaKucuk closed this Jun 6, 2026
@TaliaKucuk TaliaKucuk reopened this Jun 6, 2026
@TaliaKucuk
Copy link
Copy Markdown
Author

TaliaKucuk commented Jun 6, 2026

Hi I have now edited the code so that the footer is fixed and does not overlap with main content. I've also added the changelist to PR description.

@TaliaKucuk TaliaKucuk added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 6, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TaliaKucuk @cjyuan