Manchester | 26-ITP-May | John Robinson | Sprint 1 | Form Controls#1301
Manchester | 26-ITP-May | John Robinson | Sprint 1 | Form Controls#1301JohnRob-jnr wants to merge 38 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
JohnRob-jnr
changed the title
JohnRob-jnr
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
How can you ensure a lighthouse score of 100?
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| <form class="order-form"> |
There was a problem hiding this comment.
I see 2 errors when I paste the code in the w3 validator: https://validator.w3.org/nu/#textarea
How can you fix them?
There was a problem hiding this comment.
Thank you, I have fixed those issue
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| <form class="order-form"> | ||
| <h2>T Shirt Order Form</h2> |
There was a problem hiding this comment.
The formatting standard for HTML elements is to use indentation on children elements. This makes it easier to understand the structure. How can you ensure consistent formatting in your code automatically?
| <!-- Name Field --> | ||
| <div class="form-group"> | ||
| <label for="name">Full Name</label> | ||
| <input type="text" id="name" name="name" placeholder="John Robinson" required> |
There was a problem hiding this comment.
How can you ensure that the input requires 2 characters?
There was a problem hiding this comment.
I have added the regular expression object to require this input
Luro91
added
Reviewed
JohnRob-jnr
added
Needs Review
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
2 participants
Self checklist
Changelist
Created a form for T Shirts & have added CSS for styling that page
Questions