Skip to content

feat: use isolation for with samply#404

Open
GuillaumeLagrange wants to merge 1 commit into
cod-2810-check-samply-possibilitieslimitations-regarding-additionalfrom
cod-2844-re-enable-runner-isolation-for-samply-profiler
Open

feat: use isolation for with samply#404
GuillaumeLagrange wants to merge 1 commit into
cod-2810-check-samply-possibilitieslimitations-regarding-additionalfrom
cod-2844-re-enable-runner-isolation-for-samply-profiler

Conversation

@GuillaumeLagrange

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the requires_isolation() -> false override from SamplyProfiler, causing samply to inherit the trait-default of true and run inside the systemd-run isolation scope just like the perf profiler.

  • Isolation now applies to samply: previously samply bypassed the systemd-run isolation scope; after this change, the full samply record … -- <benchmark> invocation executes within the scope.
  • No custom rule violations in the changed lines; the diff is four lines removed.

Confidence Score: 5/5

Safe to merge; the change is a four-line removal that opts samply into the same isolation path already used by every other profiler.

The diff is minimal and the intent is clear. Samply now shares the same systemd-run execution path as the perf profiler, which already uses isolation. No logic, no new code paths, and no rule violations were introduced.

No files require special attention.

Important Files Changed

Filename Overview
src/executor/wall_time/profiler/samply/mod.rs Removes the requires_isolation() -> false override; samply now inherits the trait default of true and participates in the systemd-run isolation scope.

Sequence Diagram

sequenceDiagram
    participant E as WallTimeExecutor
    participant P as SamplyProfiler
    participant SR as systemd-run (isolation)
    participant S as samply record
    participant B as Benchmark

    E->>P: requires_isolation()
    note over P: before: false<br/>after: true (trait default)
    P-->>E: true
    E->>SR: wrap command with isolation scope
    SR->>S: spawn samply record
    S->>B: spawn benchmark process
    B-->>S: exit
    S-->>SR: profile saved
    SR-->>E: scope exits
Loading

Reviews (1): Last reviewed commit: "feat: use isolation for with samply" | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks


Comparing cod-2844-re-enable-runner-isolation-for-samply-profiler (22d1089) with cod-2810-check-samply-possibilitieslimitations-regarding-additional (ca886e6)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants