Skip to content

ci: use latest runner-version for darwin flamegraph benchmark#63

Open
not-matthias wants to merge 1 commit into
mainfrom
ci/use-latest-runner-version
Open

ci: use latest runner-version for darwin flamegraph benchmark#63
not-matthias wants to merge 1 commit into
mainfrom
ci/use-latest-runner-version

Conversation

@not-matthias

@not-matthias not-matthias commented Jun 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@not-matthias not-matthias marked this pull request as ready for review June 12, 2026 10:57
@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown

Greptile Summary

Cleans up a temporary workaround in the macOS flamegraph benchmark CI job by replacing the pinned pre-release branch runner version with runner-version: latest now that the underlying fix has shipped.

Confidence Score: 5/5

Safe to merge — this is a one-line cleanup removing a temporary branch-pinned runner workaround.

The only change is swapping a pinned pre-release branch runner (branch:cod-2762-samply-sigkills-dsymutil) for latest, which is consistent with how the rest of the CI workflow handles runner versions. The removed TODO comment confirms this was always meant to be temporary.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Removes the temporary branch-pinned runner workaround and replaces it with runner-version: latest in the walltime-macos-test job.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[walltime-macos-test job] --> B[actions/checkout]
    B --> C[actions/setup-go]
    C --> D[rust-install]
    D --> E[cargo build --release]
    E --> F["CodSpeedHQ/action@main\nmode: walltime\nrunner-version: latest"]
    F --> G[Run BenchmarkFibonacciDarwin]

    style F fill:#90EE90,stroke:#333
Loading

Reviews (1): Last reviewed commit: "ci: use latest runner-version for darwin..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 48 untouched benchmarks
🆕 1 new benchmark
⏩ 1 skipped benchmark1

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 BenchmarkFibonacciDarwin N/A 265.5 µs N/A

Comparing ci/use-latest-runner-version (eb49ff4) with main (f6291c8)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants