docs: correct the csa-skilljar-setup.ps1 comment - #48
Merged
Conversation
… truth The comment asserted the .ps1 'does NOT exist yet'. It landed in CSA-Plugins#54, so the note is now false in the one file a reader would check to find out. Keeps what is still true and load-bearing - why the list, and why the loop uses `continue` - since that is what carried csa-skilljar between being listed here and its script existing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment in
Invoke-CSAInternalSetupasserts thatcsa-skilljar-setup.ps1"does NOT exist yet". It landed in CloudSecurityAlliance-Internal/CSA-Plugins#54, so that note is now false — in the one file a reader would open to find out.Keeps the part that is still true and load-bearing: why the list exists, and why the loop uses
continuerather thanreturn. That tolerance is exactly what carriedcsa-skilljarthrough the window between being listed here (#46) and its script existing, with no change needed in this file — which is worth recording as a thing that worked, not deleting along with the stale half.