docs: close the csa-skilljar-setup.ps1 gap - #47
Merged
Conversation
The .ps1 landed in CSA-Plugins#54, so Invoke-CSAInternalSetup's existing reference now resolves and Windows members get the Skilljar server on their next run. Nothing in this repo changed - the loop already listed it and already skipped it cleanly while it was missing, which is why the gap was recorded here rather than left as a silent no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csa-skilljar-setup.ps1now exists (CloudSecurityAlliance-Internal/CSA-Plugins#54), soInvoke-CSAInternalSetup's existing reference resolves and Windows members pick up the Skilljar MCP server on their next run.No code change here — the loop already listed the script and already skipped it cleanly while it was absent. That correct-looking skip was exactly why the gap was written down: a skip that is correct behaviour is indistinguishable from a skip that is a bug, so the only way to tell them apart was to record which one this was.
Removes the entry, and with it the now-empty
### Open worksection.