Skip to content

add arm windows npipe file - #1

Open
ph4r05 wants to merge 1 commit into
Cloud-Foundations:v2from
ph4r05:pr
Open

add arm windows npipe file#1
ph4r05 wants to merge 1 commit into
Cloud-Foundations:v2from
ph4r05:pr

Conversation

@ph4r05

@ph4r05 ph4r05 commented May 27, 2024

Copy link
Copy Markdown

I tried copying znpipe_windows_amd64.go to znpipe_windows_arm64.go and it worked.

go install golang.org/x/sys/windows/mkwinsyscall@latest
GOOS=windows GOARCH=arm64 ~/go/bin/mkwinsyscall.exe npipe_windows.go > znpipe_windows_arm64.go

Turns out, znpipe_windows_arm64.go is the same as znpipe_windows_amd64.go

@rgooch
rgooch requested a review from cviecco June 9, 2024 17:04
@cviecco

cviecco commented Jun 11, 2024

Copy link
Copy Markdown
  1. Why has this not landed upstream?
  2. This file seems identical to the amd64 file... why not just update the build directives in the other file? (and rename it to reflect is for windows?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants