Repository navigation
Conversation
…1173) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the per-source-kind ClickPipes models out of models/clickpipes/mod.rs into kafka, kinesis, pubsub, object_storage, postgres, mysql, mongodb and bigquery submodules, plus schema_discovery and reverse_private_endpoints. mod.rs keeps the top-level pipe types, the shared destination, field mapping, settings, scaling and state types, the source unions, and the credentials shared across kinds (MskIamUser, PLAIN, ServiceAccount), and glob re-exports every submodule so models::* paths are unchanged. Moves only: the item text is unchanged; only mod/use lines were added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each models/clickpipes/*.rs module maps to the clickpipes suite, like models/clickpipes.rs did. The old path stays mapped so diffs that name it remain classified. The install classifier only inventories crates/clickhousectl and never mapped models/clickpipes.rs, so it needs no entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1173 (5 of 6:
models/clickpipes). Stacked on #1179.Summary
This splits
src/models/clickpipes.rs(4.7k lines) intosrc/models/clickpipes/. Behaviour and the public surface are unchanged.models.rsstill haspub use clickpipes::*, andmod.rsglob re-exports every submodule, so every crate-root andmodels::*path resolves as before.mod.rsClickPipe,ClickPipeState,ClickPipePostRequest/ClickPipePatchRequest,ClickPipeSource/ClickPipePostSource/ClickPipePatchSource, destination, field-mapping, settings, scaling (including CDC) and state-patch types,ClickPipesServiceContext, and the credentials several kinds share (MskIamUser,PLAIN,ServiceAccount)kafka.rsAzureEventHub,MutualTLSkinesis.rspubsub.rsClickPipePostPubSubSourceunionobject_storage.rspostgres.rsmysql.rsmongodb.rsbigquery.rsClickPipeBigQuerySource,ClickPipeMutateBigQuerySource), their variants, pipe settings, table mappingsschema_discovery.rsClickPipeSchemaDiscovery*reverse_private_endpoints.rsReversePrivateEndpoint*,CreateReversePrivateEndpoint*,UpdateReversePrivateEndpoint,CustomPrivateDnsMapping*Each
discriminated_union!invocation,Default/Displayimpl andFromconversion sits next to the enum it belongs to, so enum declarations stay literal source for the analyzer.Commits
git mv.clickpipes.rs→clickpipes/mod.rs(100% similarity), so blame follows the file.mod,pub use <kind>::*anduse super::{...}lines. The 190pub struct/enum/typenames match. Review it withgit show --color-moved=dimmed-zebra.scripts/classify-cloud-integration.pymaps each newmodels/clickpipes/*.rsto{"clickpipes"}, the same as the parent. The old path stays mapped, so diffs that name it remain classified. The test fixture lists the new paths. The install classifier only inventoriescrates/clickhousectl, so it needs no entry..git-blame-ignore-revsentry for commit 2. This SHA must be updated if the stack is rebased before merge.crates/clickhouse-cloud-api/AGENTS.mdlayout section and the crate README's structure table now say a large model domain may be a directory.Visibility widenings
None. Every moved item was already
pub.Tests
--listoutput is byte-identical.model_facade_testandspec_coverage_testpass untouched.python3 scripts/check-openapi-drift.py --dry-rungives the same output before and after (no actionable drift).cargo fmt --allpasses, as does clippy for the library crates with--all-targets.clickhousectlclippy configurations pass, as docargo check -p clickhousectl --no-default-featuresandcargo check --workspace --all-features.cargo test -p clickhouse-cloud-api -p clickhouse-openapi-analyzerand the Python classifier tests pass.Merge with a merge commit, not a squash. The
.git-blame-ignore-revsentry names this PR's move commit. A squash merge would leave it pointing at a commit that isn't on main, and git would silently ignore it.🤖 Generated with Claude Code
Note
Low Risk
Mechanical file split with preserved public re-exports; no runtime or serde shape changes intended beyond moving code.
Overview
Replaces the ~4.7k-line
src/models/clickpipes.rswith asrc/models/clickpipes/tree: shared pipe types stay inmod.rs, and source-specific models move into per-kind modules (Kafka, Kinesis, Postgres, etc.) plusschema_discovery.rsandreverse_private_endpoints.rs.pub use clickpipes::*inmodels.rsand glob re-exports inmod.rskeep all existing crate-root andmodels::*paths unchanged—this is layout only, not an API change.Supporting updates:
.git-blame-ignore-revsentry for the move commit, AGENTS.md / README notes that large model domains can be directories, andscripts/classify-cloud-integration.py(and its test) map each new file to theclickpipesintegration suite.Reviewed by Cursor Bugbot for commit 91c7d39. Bugbot is set up for automated code reviews on this repo. Configure here.