Repository navigation
Conversation
`ClickStackLogSource` and `ClickStackLogSourceResponse` gain optional `event_name_expression` (`eventNameExpression`) and `severity_number_expression` (`severityNumberExpression`), and the `TryFrom` write-back carries both. With this change the library covers the live spec with no actionable drift. `clickhousectl` reads source config files strictly into these library types, so the new keys are accepted there from this commit; CLI coverage and docs follow separately. Fixes #1144 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 4 in the #1144 drift stack. Fixes #1144.
ClickStackLogSourceandClickStackLogSourceResponsegain optionalevent_name_expression(eventNameExpression) andseverity_number_expression(severityNumberExpression), both nullable strings in the spec. TheTryFromwrite-back carries both.nulland wire-name tests are extended, and a new write-back round trip is added. Library README updated.clickhousectlreads source config files strictly into these library types, soclickstack source create|update --fileaccepts the new keys from this PR. It needs no code change. Part 4 pins the behaviour.At this head,
python3 scripts/check-openapi-drift.py --dry-runagainst the live spec reports no actionable drift. The library tests (includingspec_coverage_testand the analyzerentrypoint_test), library clippy, bothclickhousectlclippy configurations,cargo check --workspace --all-featuresandcargo test -p clickhousectlpass.🤖 Generated with Claude Code
Note
Low Risk
Additive optional API model fields and conversions with expanded serde tests; no auth, networking, or behavior changes beyond accepting new JSON keys.
Overview
Aligns ClickStack log source models with the Cloud API by adding optional
event_name_expressionandseverity_number_expressiononClickStackLogSourceandClickStackLogSourceResponse(wire nameseventNameExpression/severityNumberExpression) for mapping OpenTelemetry log EventName and SeverityNumber.TryFromfor log sources now copies both fields on response-to-request write-back. Existing serde behavior applies: absent ornullstaysNone, set values serialize under their wire names. Struct-literal callers must set the new fields toNoneor use..Default::default().Tests cover optional/null handling, wire-name serialization, and a full JSON round trip; the crate README documents the new fields.
Reviewed by Cursor Bugbot for commit 6b49176. Bugbot is set up for automated code reviews on this repo. Configure here.