Repository navigation
fix: stop pack:verify leaving its test server running on Windows - #26
Open
ChrystianSchutz wants to merge 1 commit into
Open
ChrystianSchutz wants to merge 1 commit into
ChrystianSchutz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows the installed bin is a
.cmdshim spawned throughcmd.exe(shell: true), sochild.kill()instopChildonly killed the shell. The ThreadShelf server it started kept running with the inherited stdout pipe open, sonpm run pack:verify | tailnever finished even after all checks passed.stopChildnow usestaskkill /T /Fon Windows to end the whole process tree. Other platforms are unchanged.Testing
npm run pack:verify 2>&1 | tail -3on Windows: 20/20 checks, exits in ~22 s, and no server stays listening on ports 3900–3989. It previously hung until the server was killed by hand.