Fix fixed Browser debugger port publication race - #856
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium can create
DevToolsActivePortbefore its contents are written. The fixed Browser worker previously parsed the file as soon as it existed, intermittently returningerrorbefore navigation. Wait for a newline-terminated port record within the existing execution deadline, and reject complete malformed or out-of-range ports.Fixes #855.
The readiness wait stops when Chrome exits or the original deadline expires. No timeout increase, navigation retry, new Browser capability, authorization change, or relaxed cleanup check is introduced. The runtime/result schemas and independent Host grant remain unchanged.
Validation:
git diff --checkpassed. Only the fixed Browser worker and its existing test file change.