Skip to content

fix: repair service pool discovery and management - #1731

Merged
ctkm-aelf merged 1 commit into
mainfrom
fix/service-pool-cli-ui
Oct 2, 2026
Merged

ctkm-aelf merged 1 commit into
mainfrom
fix/service-pool-cli-ui

Conversation

@ctkm-aelf

@ctkm-aelf ctkm-aelf commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Fix service-pool connection discovery in the UI and CLI while preserving existing REST operation-check defaults. Draft selections retain compatibility controls across search and pagination.
  • Rework the pool page and editor around ownership, routing, and connection order. Fix Save state, hidden AI models, mobile overflow, menu pointer locks, rapid reopening, and keyboard focus.
  • Fix CLI identifier resolution and unchecked-health output. Add regressions for 429 fallback audits, legacy weighted routing, inspection boundaries, and editor interactions.

Follow-up to #1680 and #1717. Acceptance details and commands are in the validation report.

Test Plan

  • Local MongoDB 8 integration checks: 108 service-pool tests and 69 related billing, recovery, node, and adapter tests passed.
  • CLI pool tests: 31 passed. Independent live CLI/API/UI smoke: 28 checks passed using real local binaries and disposable data.
  • After rebasing onto main: 4,106 frontend tests across 410 files, lint, TypeScript, production build, CLI wizard-bundle freshness, and the complete 20-check Chromium regression sequence passed. The extraction also passed all 24 focused tests.
  • Chromium checks passed for 20 flows, including 30 desktop and 10 mobile cancellation cycles, keyboard focus, and zero console/page errors. Ten immediate enable/disable toggles and accepted-length labels at four viewport sizes passed.
  • Workspace Clippy with warnings denied, Rust formatting, backend boundary validation, and diff whitespace checks passed.

Checklist

  • Code follows the project architecture rules and frontend component-size convention.
  • No hardcoded secrets or credentials.
  • Error messages do not leak internal details.
  • API reference and service-pool documentation updated.

CI result

All applicable checks passed for commit 9a6dd8b05615e1ae93599a3c1210fb394ab2d66a, including CI Pipeline, backend and CLI tests, frontend, all coverage gates, all KMS combinations, image inputs, wizard freshness, and CodeQL. CI run. GitHub reports no merge conflicts with main.

Separate connection inventory from operation checks so editors can select valid connections without guessing a path. Preserve REST defaults, owner boundaries, and revision checks while fixing CLI identifier resolution and pool form and dialog interactions.
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

📊 Code coverage

Component Lines Threshold Status Δ vs base
Backend (nyxid) 87.53% 73% ✅ — 0.00
CLI (nyxid-cli) 69.67% 64% ✅ 🔺 +0.10
Frontend (vitest) 71.87% 15% ✅ 🔺 +0.11

Gate: line coverage must stay at or above the threshold. Ratchet plan (W21): Backend → 55%, CLI → 50%, Frontend → 30% by quarter end.

@ctkm-aelf
ctkm-aelf merged commit c811546 into main Oct 2, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant