Repository navigation
fix: draw no default table cell border, and let the ooxml sync push to main - #408
Conversation
Every cell started from a 1px border (white at 30% in vue, svelte and vanilla, white or gray in react) that nothing in the deck asked for. A cell side the deck gives no border, for example <a:lnL w="0"><a:noFill/></a:lnL>, therefore still drew one and pushed the cell content in by a pixel, so text no longer lined up with PowerPoint's own rendering. Cells now carry only the borders their style gives, as in the angular binding. React and vue keep a faint grid while a table is being edited, so the cells of a borderless table can still be found. Closes #406 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VwbAnmRAgQ3PsfiLH6RwoF
main requires the ci-success check, which only an admin may bypass, so the sync's push with the default token was rejected after its checks had passed. The existing RELEASE_TOKEN secret is now passed through to the reusable workflow, which uses it for the push. Closes #407 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VwbAnmRAgQ3PsfiLH6RwoF
Cross-binding parity checkThis is advisory only and does not block the PR. It looks at changed file paths, so it cannot tell a genuinely framework-specific change from a parity gap. If it is wrong here, just say so in a comment.
UI source changed in 4 of 5 bindingsChanged: React, Vue, Svelte, Vanilla. Not changed: Angular. If this is a new UI feature, it needs to land in all five. If it is a fix, please confirm in the PR description whether the other bindings have the same defect, and fix the ones that do. If the change really is framework-specific, say so and this note can be ignored. Several bindings changed, but
|
What does this change?
Two fixes, one commit each.
Table cells draw no default border (closes #406). Vanilla, Svelte and Vue started every cell from
border: 1px solid rgba(255, 255, 255, 0.3), and React gave every cell aborderclass (border-white/30in the rawXml renderer,border-gray-400/50in the structured one). A side the deck gives no border (for example<a:lnL w="0"><a:noFill/></a:lnL>) still drew it and pushed the cell content in by about a pixel. Cells now carry only the borders their style gives, which is what the Angular binding already did. React and Vue keep a faint grid while a table is being edited (React's existing editable branch, and Vue's--editablemodifier), so the cells of a borderless table can still be found. Vanilla and Svelte have no editing path, so they draw none.Tests: vanilla and Svelte assert a plain cell has no border while a cell with an explicit left border keeps it; React asserts no
borderclass on a read-only cell; Vue guards the stylesheet, because scoped SFC CSS is not applied in jsdom.The ooxml sync can push to the protected
main(closes #407). The run in #407 passed every check (all ten packages green); the failing step wasPush the bump, rejected withRequired status check "ci-success" is expected.mainrequires that check and only an admin may bypass it, and the reusable workflow pushed with the default token. The caller now passessecrets: inherit, so the repository's existingRELEASE_TOKENdoes the push. The reusable workflow inooxmluses it when present and now reports a refused push as "could not be pushed" instead of a failed verification.How was it verified?
oxlint --deny-warningspass on the changed files.