Repository navigation
Say when a cycle report covers more modules than its example - #5
Merged
Merged
Conversation
The cycles rule reports each strongly connected component once, with the shortest cycle through its first module as the example. When the group is larger than that cycle, "Modules [30 modules] form a dependency cycle: A -> B -> A" read as a single two-module cycle. Running Cordon on Bagisto, advisingapp and LaravelEcomm produced exactly that message in all three. The message now says the modules "are tangled in dependency cycles, such as A -> B -> A" in that case. When the example covers every module, the message is unchanged. The violation's target stays the same, so existing baselines still match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
cyclesrule reports each group of mutually reachable modules once, with the shortest cycle through its first module as an example. When the group is larger than that cycle, the message reads as if the example were the whole cycle:Running Cordon on Bagisto (30 modules in the group), advisingapp (29) and LaravelEcomm (25) produced this message in all three.
Change
When the group has more modules than the example cycle, the message now says so:
targetis unchanged, so existing baselines still match.Tests
composer checkpasses (Pint, PHPStan, Pest: 120 passed, 1 skipped).Not in this PR
--moduleand the Pest expectation assign a cycle only to the modules on the example path (ADR 0005), socordon:verify --module=Saleson Bagisto does not report the cycleSalesis part of. Changing that needs an ADR.