Repository navigation
Add support for Poseidon M60 - #41
Conversation
Chreece
left a comment
There was a problem hiding this comment.
Thank you, @decompil3d, for adding Poseidon M60 support, collecting the Android HCI evidence, and testing on your own soundbar. The separate model profile and keeping unverified EQ/Style writes disabled are helpful choices.
I reviewed commit 069b76a973497b7ef676b55ce34e1e67ffc6c54d, focusing on preserving existing functionality. I found no regression in the existing D80/D70/A40 scenarios checked. There is one M60 Custom-mode acknowledgement issue to address before merging; the inline comment describes the reproduction and suggested coverage.
Validation performed locally:
- PR: 112 passed, 1 failed. Base: 108 passed, 1 failed. The same changelog-consistency test fails on both branches, so this is a pre-existing repository issue, not a regression introduced here.
- Existing models' exposed controls and 2,048 sound-mode decoding cases matched the base branch.
- All eight D80 sound-mode command sequences and resulting states matched the base branch.
- Python compilation and JSON validation passed.
These were offline checks using Python 3.12 and an in-memory BLE peer; I did not test physical hardware. GitHub's Tests/Validate workflows were marked action_required at review time, so HACS/Hassfest and the CI run still need to complete before merging.
Please address the acknowledgement case below and add a runtime test using the sanitized captured M60 response. Thanks again for the contribution!
Chreece
left a comment
There was a problem hiding this comment.
Thank you, @decompil3d, for addressing the acknowledgement issue and adding the captured M60 response and runtime regression test.
I re-reviewed 9f1695da56d55648a00db2196d8d767385d204c2 against the current master, including the new Aura A60 Pro support. The requested change is resolved: the validated 41-byte Custom response now completes the pending M60 request without waiting for the timeout or issuing an INFO fallback query. The handling is scoped to the M60 Custom transaction, and the D80 Custom EQ/Style paths remain intact.
Validation:
- 121 tests passed on the combined current-master/PR tree; compilation and diff checks passed.
- Replayed the M60 full response with the fallback query explicitly disabled: selection completed within the 0.5-second test deadline, with no D80 EQ curve exposed.
- Wrong-group, wrong-command, wrong-profile, truncated and invalid frequency/gain replies did not complete the pending M60 request.
- Existing models' exposed controls, 2,560 sound-mode decoding cases and all eight D80 sound-mode command/state sequences matched current master. This includes A60 Pro regression coverage.
- GitHub Tests, HACS and Hassfest are green for this revision.
These were offline runtime checks; I did not perform additional physical hardware testing. Approved for merge. Thanks again for contributing M60 support!
Summary
This PR adds support for the Poseidon M60 soundbar. I've tested it locally on my own soundbar and it works as expected.
Validation
Protocol changes
I gathered HCI snoop logs from the Android app to confirm the protocol for the M60. It brings only minor differences as compared to the already supported D70 etc. The main difference is around sound mode selection, so the PR refactors that to allow for model-specific sound mode protocols.