Skip to content

chore: stop tracking the .coverage data file (#304) - #305

Merged
patrick-chinchill merged 1 commit into
mainfrom
sync/4.41-hyg
Oct 1, 2026
Merged

patrick-chinchill merged 1 commit into
mainfrom
sync/4.41-hyg

Conversation

@patrick-chinchill

@patrick-chinchill patrick-chinchill commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Stops tracking .coverage, the coverage.py SQLite data file. Before this change, every pytest --cov run showed it as modified in every worktree.

  • git rm --cached .coverage
  • .gitignore: .coverage was already listed, but that pattern only matches the exact name. Added .coverage.* so parallel-mode files (.coverage.<host>.<pid>.<rand>) are ignored too.
  • CHANGELOG bullet under "Unreleased (4.41 wave)" (tooling only).

Verify-first findings

  • CI (.github/workflows/test.yml) runs pytest --cov=chat_sdk --cov-fail-under=70, which writes a fresh data file. Nothing reads the committed copy.
  • pyproject.toml has no [tool.coverage] section. The hatch sdist uses an explicit include allowlist that already leaves .coverage out.
  • No test, script or doc refers to the .coverage file.

Acceptance

  • After uv run pytest tests/ -q --cov=chat_sdk --cov-fail-under=70 (93.40% coverage, 7882 passed, 24 skipped), .coverage is on disk and git status is clean. git check-ignore -v shows .coverage matched by .gitignore:19 and .coverage.host.1.abc by .gitignore:20.
  • Full validation is green: ruff check/format, audit (0 hard failures), --check-docs, --strict (all TS tests have Python equivalents), pytest, and pyrefly (0 errors).

Upstream mapping / tests / fidelity

No upstream commits and no tests to port; this is a Python-repo hygiene change.
Delta vs committed report (HEAD): missing 100 -> 100 (+0). fidelity_target.json is unchanged.

Divergences

None.

Consumer impact

None. When a checkout pulls this commit, git deletes the local .coverage file. The next coverage run writes a new one.

Closes #304
Part of #184

Merge gate

  • Review findings: none were reported, so nothing was fixed or declined.
  • Main integration: the branch already contains origin/main (a78919d). The merge was a no-op and there were no conflicts.
  • Local validation on da1bd83: everything is green. ruff check and format pass, the audit has 0 hard failures, --check-docs passes, and --strict finds all TS tests with Python equivalents. pytest: 7882 passed, 24 skipped. pyrefly: 0 errors.
  • gpt-6-astra: 1 round on da1bd83. Clean, with no actionable findings.
  • Bots: CodeRabbit hit its rate limit and posted no review. There are no inline comments or reviews.
  • CI on da1bd83: Tests 3.12 and 3.13, CodeQL, and Analyze (python/actions) all pass. Lint & Type Check did not run. Its workflow has a path filter (src/, tests/, scripts/, pyproject.toml, docs), and this PR changes none of those paths. Lint, format and pyrefly passed locally instead.

Untrack the coverage.py SQLite data file and also ignore .coverage.*
(parallel-mode files). CI's pytest --cov writes a fresh file and there
is no [tool.coverage] config, so nothing read the committed copy.
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: cf358d7b-12c1-4522-9634-ec9f60de9fee

📥 Commits

Reviewing files that changed from the base of the PR and between a78919d and da1bd83.

📒 Files selected for processing (3)
  • .coverage
  • .gitignore
  • CHANGELOG.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patrick-chinchill
patrick-chinchill marked this pull request as ready for review October 1, 2026 10:16
@patrick-chinchill

Copy link
Copy Markdown
Collaborator Author

Merge gate: CI green (test 3.12, test 3.13, CodeQL, Analyze python/actions; Lint & Type Check path-filtered out since the PR touches only .coverage/.gitignore/CHANGELOG.md — ruff check/format + pyrefly (0 errors) re-run locally green on da1bd83); local Codex review (gpt-6-astra, xhigh, --base origin/main) on da1bd83: clean, no actionable findings; 1 astra round; origin/main (a78919d) already an ancestor, no re-merge needed; bots: CodeRabbit rate-limited, no reviews or inline comments. Merging with --admin (Protect Main requires a code-owner approval).

@patrick-chinchill
patrick-chinchill merged commit 3f06859 into main Oct 1, 2026
6 checks passed
@patrick-chinchill
patrick-chinchill deleted the sync/4.41-hyg branch October 1, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[4.41/HYG] Stop tracking the .coverage data file

1 participant