Repository navigation
chore: stop tracking the .coverage data file (#304) - #305
Conversation
Untrack the coverage.py SQLite data file and also ignore .coverage.* (parallel-mode files). CI's pytest --cov writes a fresh file and there is no [tool.coverage] config, so nothing read the committed copy.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge gate: CI green (test 3.12, test 3.13, CodeQL, Analyze python/actions; Lint & Type Check path-filtered out since the PR touches only .coverage/.gitignore/CHANGELOG.md — ruff check/format + pyrefly (0 errors) re-run locally green on da1bd83); local Codex review (gpt-6-astra, xhigh, --base origin/main) on da1bd83: clean, no actionable findings; 1 astra round; origin/main (a78919d) already an ancestor, no re-merge needed; bots: CodeRabbit rate-limited, no reviews or inline comments. Merging with --admin (Protect Main requires a code-owner approval). |
Summary
Stops tracking
.coverage, the coverage.py SQLite data file. Before this change, everypytest --covrun showed it as modified in every worktree.git rm --cached .coverage.gitignore:.coveragewas already listed, but that pattern only matches the exact name. Added.coverage.*so parallel-mode files (.coverage.<host>.<pid>.<rand>) are ignored too.Verify-first findings
.github/workflows/test.yml) runspytest --cov=chat_sdk --cov-fail-under=70, which writes a fresh data file. Nothing reads the committed copy.pyproject.tomlhas no[tool.coverage]section. The hatch sdist uses an explicitincludeallowlist that already leaves.coverageout..coveragefile.Acceptance
uv run pytest tests/ -q --cov=chat_sdk --cov-fail-under=70(93.40% coverage, 7882 passed, 24 skipped),.coverageis on disk andgit statusis clean.git check-ignore -vshows.coveragematched by.gitignore:19and.coverage.host.1.abcby.gitignore:20.--check-docs,--strict(all TS tests have Python equivalents), pytest, and pyrefly (0 errors).Upstream mapping / tests / fidelity
No upstream commits and no tests to port; this is a Python-repo hygiene change.
Delta vs committed report (HEAD): missing 100 -> 100 (+0).fidelity_target.jsonis unchanged.Divergences
None.
Consumer impact
None. When a checkout pulls this commit, git deletes the local
.coveragefile. The next coverage run writes a new one.Closes #304
Part of #184
Merge gate
origin/main(a78919d). The merge was a no-op and there were no conflicts.da1bd83: everything is green. ruff check and format pass, the audit has 0 hard failures,--check-docspasses, and--strictfinds all TS tests with Python equivalents. pytest: 7882 passed, 24 skipped. pyrefly: 0 errors.da1bd83. Clean, with no actionable findings.da1bd83: Tests 3.12 and 3.13, CodeQL, and Analyze (python/actions) all pass. Lint & Type Check did not run. Its workflow has a path filter (src/,tests/,scripts/,pyproject.toml, docs), and this PR changes none of those paths. Lint, format and pyrefly passed locally instead.