Repository navigation
Intake: a deleted issue no longer stops the week-old cleanup - #118
Merged
Merged
Conversation
Issues #1-#5 in the reports repo were deleted by hand. When their reports turned 7 days old, reading the issue answered 410, the run threw before removing the report from Firestore, and every run from 2026-10-18 21:47 to 2026-10-20 14:25 failed on the same report. Now a 404/410 reads as "gone": the note is skipped and the report is still removed. Already live in the reports repo (floe-market-reports#13); this keeps intake/ in step so the next copy over doesn't bring the bug back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intake in the reports repo failed on every run from 2026-10-18 21:47 to 2026-10-20 14:25 UTC with
GitHub GET /issues/2: 410 This issue was deleted.Why: issues #1–#5 in the reports repo were deleted by hand. When a report turns 7 days old, the run reads its issue to add the "picture and save are gone" note. The 410 threw before the report was removed from Firestore, so the same report came up first on every run. No reports were lost: filing runs before the cleanup, and none arrived during the outage.
Fix (already merged and running in the reports repo as ChefControl/floe-market-reports#13; this keeps
intake/in step, since the reports repo is a copy of it):intake/src/github.ts:readreturnsnullwhen GitHub answers 404 or 410.intake/src/run.ts: when the issue is gone, the note is skipped but the report is still removed.test/intake.test.ts: a new test for a report whose issue was deleted. It fails on the old code and passes now; all 12 intake tests pass.🤖 Generated with Claude Code