fix: eliminate duplicate courses API requests on courses page - #530
Open
Ranjeet2063 wants to merge 2 commits into
Open
Ranjeet2063 wants to merge 2 commits into
Ranjeet2063 wants to merge 2 commits into
Conversation
- Extract `useEnrollments` hook out of `useCourses` - Use `useEnrollments()` directly on the courses list page instead of `useCourses()` - Eliminates duplicate `getCourses` network calls since `useInfiniteCourses` already fetches the catalog list Closes ChainLearnOfficial#517
❌ Deploy Preview for chainlearn failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the issue where
CoursesPagewas firing duplicate network requests to fetch the course catalog on mount.How
useEnrollments()hook out ofuseCourses()that only handles fetching and caching the user's enrollmentsCoursesPage(src/app/courses/page.tsx) to useuseEnrollments()instead ofuseCourses()useInfiniteCoursesto fetch the catalog grid (which it was already doing) while still successfully fetching the enrollment data needed for the "enrolled" badges.Closes #517