fix: resolve Stellar Wave bugs (#451-454) - #505
Merged
Merged
Conversation
- Fix ConfirmDialog preventing close while loading async action (ChainLearnOfficial#454) - Add onOpenChange handler to prevent dialog close when loading is true - Prevents user from dismissing dialog during destructive operations - Fix useSessions AbortController cleanup is unreachable (ChainLearnOfficial#453) - Move AbortController creation from callback to useEffect - Properly return cleanup function to cancel in-flight requests on unmount - Prevents stale state updates after component unmount - Fix Connect page silently swallowing profile fetch errors (ChainLearnOfficial#452) - Move success toast after successful profile fetch - Add proper error handling and display for profile fetch failures - Prevent showing success message when full connection flow fails - Fix Settings page language preference never persisted (ChainLearnOfficial#451) - Load language preference from profile on mount - Include language in profile update payload - User's language preference now persists across sessions
❌ Deploy Preview for chainlearn failed.
|
|
@devwura Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 4 interconnected bugs in the Stellar Wave feature:
Changes
1. ConfirmDialog - Prevent close while loading (#454)
handleOpenChangehandler to prevent dialog closure whenloadingis true2. useSessions - Fix AbortController cleanup (#453)
3. Connect Page - Handle profile fetch errors (#452)
4. Settings Page - Persist language preference (#451)
Testing
Each fix addresses a specific issue:
closes #451
closes #452
closes #453
closes #454