Skip to content

fix(governance): block execution of proposals with zero cast votes #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rupesh-kumar-sah wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(governance): block execution of proposals with zero cast votes #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions contracts/learn-token/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,6 +1877,10 @@ impl LearnToken {
}
}

if winning_votes == 0 {
panic!("no votes cast");
}

proposal.executed = true;
proposal.winning_choice = winning_choice;
storage::set_proposal(&env, proposal_id, &proposal);
Expand Down Expand Up @@ -3421,6 +3425,34 @@ mod tests {
assert_eq!(prop.winning_choice, 1);
}

#[test]
#[should_panic(expected = "no votes cast")]
fn test_execute_proposal_zero_votes_panics() {
let env = Env::default();
let (_admin, lt_contract_id, _) = setup(&env);
let client = LearnTokenClient::new(&env, &lt_contract_id);
env.mock_all_auths();

env.ledger().with_mut(|li| li.sequence_number = 99);
let snapshot_ledger = env.ledger().sequence();
client.snapshot(&snapshot_ledger);
env.ledger().with_mut(|li| li.sequence_number = 100);

let start = 1_000u64;
let end = 2_000u64;
let prop_id = client.create_proposal(
&SorobanString::from_str(&env, "Zero Vote Proposal"),
&2,
&start,
&end,
&snapshot_ledger,
);

// Advance time past end_time without any votes
env.ledger().with_mut(|li| li.timestamp = 2_500);
client.execute_proposal(&prop_id);
}

// ── Issue #254: storage size tracking ─────────────────────────────────

#[test]
Expand Down