batch_claim_reward does not append claim records to history -- get_claim_history is incomplete

[DeFiVC]

What

batch_claim_reward (learn-token lib.rs:717-780) does not call storage::append_claim_record() for each successful quiz claim. Compare with claim_reward (lib.rs:690-699) which appends a ClaimRecord after each successful claim.

This means get_claim_history(learner) returns an incomplete history -- rewards claimed via batch_claim_reward are missing.

// claim_reward -- appends record:
storage::append_claim_record(&env, &learner, &storage::ClaimRecord { ... }); // line 690

// batch_claim_reward -- no append_claim_record call:
storage::set_reward_claimed(&env, &learner, &course_id, &quiz_id); // line 769
events::reward_claimed(...); // line 770
successful.push_back(quiz_id); // line 771
// ... no append_claim_record

Why

get_claim_history is documented as returning the "Full reward claim history for a learner." But rewards claimed via batch are silently omitted. This breaks auditability and could confuse learners who claimed rewards via batch and see an incomplete history.

Scope

Add storage::append_claim_record() inside the batch loop (after line 770), matching the pattern in claim_reward.

Acceptance Criteria

• get_claim_history returns all claims, including those from batch_claim_reward
• Test verifies batch claims appear in history

Technical Context

• contracts/learn-token/src/lib.rs:717-780 -- batch_claim_reward
• contracts/learn-token/src/lib.rs:690-699 -- append_claim_record in claim_reward

[Tinu-ola]

@Tinu-ola has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi, please assign me to this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Tinu-ola to this issue.

[felixumeh]

@felixumeh has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi maintainer, this issue is part of my current study and I would like to work on it. Thank you

ℹ️ Repo Maintainers: To accept this application, review their application or assign @felixumeh to this issue.

[Oprimecloud]

@Oprimecloud has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi team, I'd love to take this on. If you could assign this issue to me, I'll dig into the repo and get a fix up for review shortly. Thanks!

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Oprimecloud to this issue.

[Tiwa4all]

@Tiwa4all has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

End of wave even if na just this one. Abeg.
Please nau!!! I can get it solved. Pls 🙏

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Tiwa4all to this issue.

[TheHalalHunter]

@TheHalalHunter has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi maintainer
I’d love to help out with this issue. I’ve checked the current codebase/documentation and know exactly what needs to be updated to make this clearer. I will ensure everything aligns perfectly with your existing contribution guidelines.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @TheHalalHunter to this issue.

[drmfsltdoh]

@drmfsltdoh has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

I would like to fix batch_claim_reward to properly append claim records to history — experienced in Soroban smart contracts, Rust state management, and debugging claim/history inconsistencies in reward systems.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @drmfsltdoh to this issue.

[LayanGift]

@LayanGift has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

I can handle this issue and will like to work on it, Please assign thank you.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @LayanGift to this issue.

[optimist82]

@optimist82 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi. I have reviewed this issue and would like to work on it.kindly assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @optimist82 to this issue.

[lmduy2612]

Submitted PR #513 with storage::append_claim_record added to the batch loop in batch_claim_reward and test test_batch_claim_reward_appends_claim_records_to_history verifying that history is correctly populated. All 79 token unit tests passing green.

[Ranjeet2063]

Hello maintainers,

I am interested in taking up batch_claim_reward does not append claim records to history -- get_claim_history is incomplete.

Solution overview:

1. Audit storage layout and state invariants ensuring strict auth guards.
2. Implement deterministic state transitions with safe checked arithmetic.
3. Add hermetic unit and regression tests covering authorized, unauthorized, and boundary edge cases.
4. Profile instruction and CPU/gas limits under Soroban host environment.

Could you please assign this issue to me? Looking forward to delivering a clean PR.