Skip to content

coverage.sh includes vendored code in coverage metrics #460

Description

@DeFiVC

What

The coverage.sh script excludes tests/* and scripts/* from coverage calculations but does NOT exclude vendor/*. The vendored ed25519-dalek crate is included in coverage metrics.

Why

Coverage percentages are inflated by vendored third-party code that the project doesn't own or maintain. The 80% threshold (--fail-under 80) may pass when it shouldn't because vendor code contributes easy-to-cover paths.

Scope

  • Add --exclude-files "vendor/*" to the cargo-tarpaulin command in coverage.sh

Acceptance Criteria

  • The coverage report excludes vendored code
  • The coverage percentage reflects only project-owned code

Technical Context

  • scripts/coverage.sh:12-18 — tarpaulin command missing vendor exclusion

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programenhancementNew feature or requestlowCosmetic, minor improvement, code quality, documentationrustRust language

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions