fix: Add Stellar transaction tests, reconciliation test, and webhook retry job - #550
Merged
DeFiVC merged 2 commits intoOct 2, 2026
Conversation
…retry job - Add Stellar transaction tests with valid public key mocks (ChainLearnOfficial#518) - Add reconciliation test with proper vi.hoisted() pattern (ChainLearnOfficial#519) - Add webhook retry job with failure categorization (ChainLearnOfficial#520) Issue ChainLearnOfficial#517 was already resolved (lock TTL test passes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #517, Closes #518, Closes #519, Closes #520
Type of Change
Summary
This PR addresses4 issues in the chainlearn-api repository:
Issue Fix lock TTL mismatch between test and implementation #517 (Lock TTL mismatch): Verified that the implementation and test already use consistent 30000ms TTL. No changes needed.
Issue Fix Stellar transaction tests with invalid public key mock #518 (Stellar transaction tests): Created
tests/unit/stellar/transactions.test.tswith proper Stellar SDK mocks using valid public key format andvi.hoisted()pattern.Issue Fix Vitest mock hoisting error in reconciliation test #519 (Vitest mock hoisting): Created
tests/unit/services/reconcile-pending-rewards.test.tswith propervi.hoisted()pattern to avoid mock hoisting errors.Issue Improve webhook retry logic with proper failure categorization #520 (Webhook retry logic): Created
src/jobs/process-webhook-retries.tswith:Motivation / Context