Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/modules/admin/admin-users.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
auditLogs,
} from "../../database/schema.js";
import { NotFoundError, ValidationError } from "../../utils/errors.js";
import { escapeLikePattern } from "../../utils/sanitize.js";
import { auditLog } from "../../audit/index.js";
import { logger } from "../../utils/logger.js";
import {
Expand Down Expand Up @@ -37,8 +38,8 @@ export class AdminUsersService {
const conditions = search
? [
or(
ilike(users.stellarAddress, `%${search}%`),
ilike(users.displayName, `%${search}%`),
ilike(users.stellarAddress, `%${escapeLikePattern(search)}%`),
ilike(users.displayName, `%${escapeLikePattern(search)}%`),
)!,
]
: [];
Expand Down
3 changes: 2 additions & 1 deletion src/modules/courses/course.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import { PASSING_PERCENTAGE } from "../quizzes/quiz.types.js";
import { auditLog } from "../../audit/index.js";
import { dispatchWebhook } from "../../services/webhook-dispatcher.js";
import { waitlistService } from "./waitlist.service.js";
import { escapeLikePattern } from "../../utils/sanitize.js";
import {
cacheGet,
cacheSet,
Expand Down Expand Up @@ -209,7 +210,7 @@ export class CourseService {
conditions.push(eq(courses.difficulty, query.difficulty));
}
if (search) {
const escaped = search.replace(/[%_]/g, "\\$&");
const escaped = escapeLikePattern(search);
conditions.push(
or(
ilike(courses.title, `%${escaped}%`),
Expand Down
8 changes: 8 additions & 0 deletions src/utils/sanitize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,11 @@ export function sanitizeText(input: string): string {
export function sanitizeQuizFeedback(input: string): string {
return sanitizeHtml(input, STRICT_OPTIONS);
}

/**
* Escape special LIKE pattern characters (%, _, and \) with backslashes
* to prevent wildcard injection in SQL/ORM queries (#533).
*/
export function escapeLikePattern(pattern: string): string {
return pattern.replace(/[%_\\]/g, "\\$&");
}
26 changes: 26 additions & 0 deletions tests/unit/utils/sanitize.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { describe, it, expect } from "vitest";
import {
sanitizeText,
sanitizeQuizFeedback,
escapeLikePattern,
} from "../../../src/utils/sanitize.js";

describe("sanitizeText", () => {
Expand Down Expand Up @@ -36,3 +37,28 @@ describe("sanitizeQuizFeedback", () => {
expect(out).toContain("Correct!");
});
});

describe("escapeLikePattern (#533)", () => {
it("escapes percent wildcards", () => {
expect(escapeLikePattern("100%")).toBe("100\\%");
expect(escapeLikePattern("%admin%")).toBe("\\%admin\\%");
});

it("escapes underscore wildcards", () => {
expect(escapeLikePattern("user_name")).toBe("user\\_name");
expect(escapeLikePattern("___")).toBe("\\_\\_\\_");
});

it("escapes backslashes", () => {
expect(escapeLikePattern("path\\to")).toBe("path\\\\to");
});

it("handles mixed special characters", () => {
expect(escapeLikePattern("50%_discount\\deal")).toBe("50\\%\\_discount\\\\deal");
});

it("leaves standard alphanumeric strings unchanged", () => {
expect(escapeLikePattern("GBZX...123 Stellar")).toBe("GBZX...123 Stellar");
expect(escapeLikePattern("")).toBe("");
});
});