test(feedback): mock Cohere client in test fixtures and allow optional client injection - #21
Open
ravimahatonp wants to merge 1 commit into
Conversation
…l client injection Closes ChainLearnOfficial#10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables tests to execute without requiring a real
COHERE_API_KEYenvironment variable. Previously, running tests in an environment withoutCOHERE_API_KEYresulted in a pydantic ValidationError upon importingsettings. Furthermore,FeedbackEngineinstantiated a liveCohereClientunconditionally in__init__.Changes Made
src/config.py: Provided a safe default empty string forcohere_api_keyso that importing configuration and services does not fail validation during unit testing.src/services/feedback_engine.py: Supported client dependency injection via__init__(self, client: Any = None)so that mock clients can be passed cleanly.tests/test_feedback_engine.py: InjectedMagicMock()client into theFeedbackEnginefixtures forTestFeedbackScoreComputationandTestQuickFeedback, decoupling unit tests from external Cohere client instantiation.Closes #10