fix: add cross-validation for questions/user_answers/correct_answers list lengths - #18
Open
ravimahatonp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7
Problem
GenerateFeedbackRequestacceptsquestions,user_answers, andcorrect_answersas independent lists with no cross-validation on their lengths. Infeedback_engine.py,zip(user_answers, correct_answers)silently truncates to the shorter list, causing answers to be silently dropped and incorrect score/feedback computation.Solution
@model_validator(mode="after")toGenerateFeedbackRequestthat checkslen(questions) == len(user_answers) == len(correct_answers).422 Unprocessable Entityerror with the exact lengths reported (e.g.,questions=3, user_answers=1, correct_answers=3).Test Results
All 41 tests pass (33 existing + 8 new), zero regressions.