Repository navigation
Zone editor in the wood diagram and limits in the time chart - #46
Merged
Merged
Conversation
The limits of the selected quantity (all sensors, or the selected sensor) are drawn as dashed lines with their level and value: yellow for warning, red for alarm.
The Mollier diagram shows its fixed comfort zone again, without user zones or the draw button; zones belong to the wood diagram (temperature x humidity), where a shape editor replaces free drawing.
- '+ Zone' starts a square; drag the corners, drag the dot in the middle of a side to add a corner, double-click a corner to remove it (at least 3), with mouse or touch - Click a zone in the diagram (or pick it from 'Edit zone…') to change its shape, name, sensor, notification, level and colour, or delete it - Saving and deleting require being logged in - The zone being edited is hidden from the diagram by its own callback, so the one-second refresh cannot overwrite it - Settings no longer has min/max fields or an add button for zones; it edits the other properties
…time chart; new screenshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zones move to the wood diagram with a shape editor, and limits show up in the time chart. Goes into v2.3.0 (re-release; it had not been downloaded yet).
+ Zonestarts a square; drag the corners, drag the dot in the middle of a side to add a corner, double-click a corner to remove it (at least 3). Mouse and touch. Click a zone (or pick it from Edit zone…) to change its shape and properties or delete it. Saving and deleting require being logged in.Test plan
python test_app.py: 86/86 tests pass