Skip to content

fix(android): sync upstream SystemBars fixes #8480 and #8481 - #106

Merged
cursor[bot] merged 4 commits into
plusfrom
cursor/sync-systembars-8480-8481-c628
Aug 13, 2026
Merged

fix(android): sync upstream SystemBars fixes #8480 and #8481#106
cursor[bot] merged 4 commits into
plusfrom
cursor/sync-systembars-8480-8481-c628

Conversation

@riderx

@riderx riderx commented Aug 13, 2026

Copy link
Copy Markdown
Member

What

Syncs two SystemBars fixes that are merged in ionic-team/capacitor but missing from plus:

  • #8481 — respect insetsHandling: "disable"
  • #8480 — show only the requested system bar

Plus one integration fix needed to make the two work together (details below).

Why

Both were carried by the stale upstream-sync branches, bundled with the "upstream-preferred fallback" resolution that renamed @capacitor-plus/* back to @capacitor/* and wiped the fork's changelogs. Stripping that damage from #71/#83/#85/#87/#88 also dropped these two genuine fixes on the floor. CodeRabbit flagged both as out-of-diff findings while reviewing #67, which is how they resurfaced.

They are worth having on their own merits:

How

Cherry-picked d4ad7ff and 4c6c321 with git cherry-pick -x, preserving upstream authorship.

d4ad7ff conflicted with #67, which had just landed and reworks the same methods. Resolved by keeping #67's structure and layering ionic-team#8481's config handling on top:

The third commit is a fork-specific integration fix. navBarVisible (added by #67) was only updated in the per-bar branches, but ionic-team#8480 restructured setHidden so bar.isEmpty() — the path initSystemBars uses for the hidden config — hides or shows every bar at once. With hidden: true the navigation bar was hidden while navBarVisible stayed true, so the API < 30 safe-area fallback reported a nav bar height for a bar that was not on screen. Upstream cannot have this bug because navBarVisible only exists here.

Testing

Not Tested

  • No on-device verification of insetsHandling: "disable", of hiding a single bar, or of the navBarVisible fix on an API < 30 device. All three are reasoned from the code and upstream's intent.

Opened by an AI agent (Cursor).

Open in Web Open in Cursor 

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Review in cubic

theproducer and others added 3 commits August 13, 2026 02:58
(cherry picked from commit d4ad7ff)

Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
Co-authored-by: Joey Pender <joey.pender@outsystems.com>
Co-authored-by: Pedro Bilro <pedro.gustavo.bilro@outsystems.com>
Co-authored-by: Mark Anderson <mark.anderson@outsystems.com>
(cherry picked from commit 4c6c321)
setHidden(.., "") hides or shows every bar at once, but only the
per-bar branches updated navBarVisible, so the API < 30 safe-area
fallback reported a nav bar height for a hidden bar.

Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 8 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cba469b5-cf02-4b2b-9ed0-6ecf04d3096e

📥 Commits

Reviewing files that changed from the base of the PR and between 94d9f70 and 305095d.

📒 Files selected for processing (2)
  • android/capacitor/src/main/java/com/getcapacitor/plugin/SystemBars.java
  • android/capacitor/src/test/java/com/getcapacitor/plugin/SystemBarsTest.java

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Beta npm build

Maintainers can publish one Capacitor Plus workspace package from this PR to npm for fast testing.

Comment /publish-beta <package> after the PR checks are green.

Examples:

/publish-beta core
/publish-beta cli
/publish-beta @capacitor-plus/core

If exactly one workspace package changed, /publish-beta without a package will use that package.

Packages:

  • core (@capacitor-plus/core)
  • cli (@capacitor-plus/cli)
  • android (@capacitor-plus/android)
  • ios (@capacitor-plus/ios)

The workflow will:

  • publish a prerelease package on the beta tag
  • add a pinned pr-106 dist-tag for the selected package
  • update this comment with the install command

Security note: beta publish is only enabled for branches inside this repository.

@riderx
riderx marked this pull request as ready for review August 13, 2026 03:11

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

The upstream SystemBars test only exercises setHidden's show path, so
the nav bar visibility tracking behind the API < 30 safe-area fallback
had no coverage.

Co-authored-by: Martin DONADIEU <martindonadieu@gmail.com>
@cursor
cursor Bot merged commit a63975d into plus Aug 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants