Skip to content

[Improvement] Added compression while sending docker images #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saaketh0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Improvement] Added compression while sending docker images #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ grpcio-tools
redis
pyyaml
flask
ipdb
ipython
sqlalchemy
psycopg[binary]
psutil
5 changes: 3 additions & 2 deletions ventis/controller/cloud_provider_logic/EC2/_runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,12 @@ def _bootstrap_instance(host, spec, replica_index, cfg, redis_host, redis_port,
logger.info("Transferring image %s to %s", image, host)
result = subprocess.run(
"set -o pipefail; "
f"docker save {shlex.quote(image)} | ssh -o StrictHostKeyChecking=no "
f"docker save {shlex.quote(image)} | zstd -T0 | ssh -o StrictHostKeyChecking=no "
f"-o IdentitiesOnly=yes -o ConnectTimeout=10 "
f"-o ServerAliveInterval=10 -o ServerAliveCountMax=3 "
f"-i {shlex.quote(key)} "
f"{shlex.quote(f'{ssh_user}@{host}')} 'sudo docker load'",
f"{shlex.quote(f'{ssh_user}@{host}')} "
"'set -o pipefail; zstd -d | sudo docker load'",
shell=True,
capture_output=True,
text=True,
Expand Down
4 changes: 1 addition & 3 deletions ventis/stub_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
import yaml

# Packages every agent container needs regardless of its specific business logic.
# grpcio-tools/pyyaml/ipdb/ipython aren't needed/used, but keeping to keep the scope constrained right now
# - Leave a comment if you want me to remove these, I kept them in since you originally had them but they aren't used
BASE_AGENT_REQUIREMENTS = ["grpcio", "grpcio-tools", "redis", "pyyaml", "psutil", "ipdb", "ipython", "boto3"]
BASE_AGENT_REQUIREMENTS = ["grpcio", "grpcio-tools", "redis", "pyyaml", "psutil", "boto3"]

# Workflow will always require these
BASE_WORKFLOW_REQUIREMENTS = BASE_AGENT_REQUIREMENTS + ["flask", "sqlalchemy", "psycopg[binary]"]
Expand Down
Loading