[Fix] Adding all of the files in the project directory to each image. - #51
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
generate_docker()/generate_workflow_docker() now recursively sweep every .py file under the project directory into the build context, preserving directory structure, so helper files that aren't declared as an agent entrypoint still make it into the image. Generated dirs (docker_container/, stubs/, grpc_stubs/) are excluded at the project root only, not at every depth. Stub files are placed at their agent's declared entrypoint path (mapped from global_controller.yaml) instead of a hardcoded guess, so a stub overwrites the exact real file it replaces. Guards against absolute and '..'-containing entrypoints, symlinked sources, and symlinked-destination escapes, with warnings on unsafe or unmapped stubs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
# Conflicts: # ventis/cli.py # ventis/stub_generator.py
nickhuo
added a commit
that referenced
this pull request
Aug 27, 2026
PR #51 moved each generated stub from the context root to its agent's entrypoint path, so the stub overwrites the real implementation the new sweep places there. That part is right, but it was a move rather than an addition, and the flat copy is what every caller actually imports: ModuleNotFoundError: No module named 'joke_agent' File "/app/workflow_launcher.py", line 21, in <module> exec(open("joke_workflow.py").read()) /app is sys.path[0], so `from joke_agent import JokeAgent` needs the stub at /app/joke_agent.py. Every example's workflow does this -- helloworld's `from example_agent import ExampleAgent` breaks the same way. _stub_destination becomes _stub_destinations and returns both paths, flat first. An agent's own entrypoint is still copied afterwards and wins its flat name back, so in an agent image /app/joke_agent.py is the real adapter while /app/agents/joke_agent.py is the stub; in a workflow image both are the stub. Verified end to end on examples/joke_writer against live Bedrock: the three generate_joke calls landed on replicas 0, 1 and 2, one each.
nickhuo
force-pushed
the
feature/all-the-files
branch
from
August 27, 2026 23:27
01a70f2 to
69d5405
Compare
nickhuo
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, each image getting built only gets the relevant Ventis code, plus stubs and grpc code, but any utility files in the original workflow that were not explicitly stubbed would get excluded. Fixed that.
I have not extensively looked over this code, this is just a initial release, will push any additional comments but this should still work.