Skip to content

Address linting issues #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cambis merged 2 commits into from
Aug 2, 2026
Merged

Address linting issues #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9501b6
:rotating_light: chore: address linting issue
Cambis Aug 2, 2026
c28e21d
:rotating_light: chore: silence new phpstan error
Cambis Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silent-ghosts-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cambis/silverstan": patch
---

Update coding standard
2 changes: 2 additions & 0 deletions ecs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use PhpCsFixer\Fixer\Operator\NewWithParenthesesFixer;
use PhpCsFixer\Fixer\Operator\NotOperatorWithSuccessorSpaceFixer;
use SlevomatCodingStandard\Sniffs\Namespaces\ReferenceUsedNamesOnlySniff;
use Symplify\CodingStandard\Fixer\Spacing\MethodChainingNewlineFixer;
use Symplify\EasyCodingStandard\Config\ECSConfig;

return ECSConfig::configure()
Expand Down Expand Up @@ -48,4 +49,5 @@
__DIR__ . '/stubs/Page.php',
__DIR__ . '/stubs/PageController.php',
],
MethodChainingNewlineFixer::class,
]);
2 changes: 1 addition & 1 deletion src/TypeResolver/TypeResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public function resolveDependencyFieldType(array|bool|int|string $fieldType): Ty
return new StringType();
}

if ($this->reflectionProvider->hasClass($name)) {
if ($this->reflectionProvider->hasClass($name)) { // @phpstan-ignore if.alwaysTrue
$name = $this->configurationResolver->resolveClassName($name);
}

Expand Down
2 changes: 1 addition & 1 deletion tests/ConfigurationResolver/Source/Extension/BarExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use SilverStripe\Dev\TestOnly;

/**
* @extends Extension<(Bar & static)>
* @extends Extension<(Bar&static)>
*/
final class BarExtension extends Extension implements TestOnly
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Reflection/ClassReflectionExtension/Source/Extension/FooExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use SilverStripe\Dev\TestOnly;

/**
* @extends Extension<(Foo & static)>
* @extends Extension<(Foo&static)>
*/
final class FooExtension extends Extension implements TestOnly
{
Expand Down
1 change: 0 additions & 1 deletion tests/Reflection/ClassReflectionExtension/Source/Model/Foo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
* @method Foo TypehintedHasOne()
* @method HasManyList<Foo> TypehintedHasMany()
*/

class Foo extends DataObject implements TestOnly
{
/**
Expand Down
2 changes: 1 addition & 1 deletion tests/Type/DynamicReturnTypeExtension/Source/Extension/FooExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use SilverStripe\Dev\TestOnly;

/**
* @extends Extension<(Foo & static)>
* @extends Extension<(Foo&static)>
*/
final class FooExtension extends Extension implements TestOnly
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Type/TypeSpecifyingExtension/Source/Extension/FooExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use SilverStripe\Dev\TestOnly;

/**
* @extends Extension<(Foo & static)>
* @extends Extension<(Foo&static)>
*/
final class FooExtension extends Extension implements TestOnly
{
Expand Down
Loading