Skip to content

feat: add aria-live region for CallHistoryRow status updates (Closes #683) - #794

Merged
greatest0fallt1me merged 1 commit into
CalloraOrg:mainfrom
legalienn:fix/683-callhistoryrow-aria-live
Jul 28, 2026
Merged

feat: add aria-live region for CallHistoryRow status updates (Closes #683)#794
greatest0fallt1me merged 1 commit into
CalloraOrg:mainfrom
legalienn:fix/683-callhistoryrow-aria-live

Conversation

@legalienn

Copy link
Copy Markdown
Contributor

Overview

This PR adds a polite aria-live region to CallHistoryRow so that status changes are announced to screen reader users, satisfying WCAG 4.1.3 (Status Messages). The component tracks the previous status using a useRef so announcements fire only on actual status transitions, not on unrelated re-renders.

Related Issue

Closes #683

Changes

src/components/CallHistoryRow.tsx

  • Added useEffect + useRef to track status changes and set an announcement message ("Call status updated to success." / "Call status updated to error.")
  • Added a visually hidden <span role="status" aria-live="polite" aria-atomic="true"> that renders the announcement text for screen readers
  • Added useEffect and useRef imports

src/components/CallHistoryRow.test.tsx

  • Added test: announces status changes through the polite live region
  • Added test: does not announce when status stays the same (avoids false positives)
  • Fixed a pre-existing duplicate import

Verification Results

npm test -- src/components/CallHistoryRow.test.tsx
✅ 40/40 passed

npm test -- src/components/CallHistoryRow.test.tsx src/pages/CallHistoryRow.test.tsx
✅ 39/39 passed (page-level test unaffected)
Acceptance Criteria Status
Status changes announced to SR users ✅ Polite live region fires on status transition
No false announcements on unrelated re-renders useRef tracks previous status, fires only on change
WCAG 4.1.3 (Status Messages) satisfied role="status" + aria-live="polite" + aria-atomic="true"
Dark mode / design tokens consistent ✅ No visual change — region is sr-only

…loses CalloraOrg#683)

Add a visually hidden aria-live="polite" region that announces call status
changes to screen reader users, satisfying WCAG 4.1.3 (Status Messages).
Tracks previous status with a useRef so announcements fire only on actual
changes, not on unrelated re-renders.

Tests added:
- Announces status changes through the live region
- Does not announce when status stays the same
@drips-wave

drips-wave Bot commented Jul 28, 2026

Copy link
Copy Markdown

@legalienn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@greatest0fallt1me
greatest0fallt1me merged commit d870a90 into CalloraOrg:main Jul 28, 2026
0 of 3 checks passed
@greatest0fallt1me

Copy link
Copy Markdown
Contributor

LGTM ✅ solid work — thanks for taking this on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add aria-live region for CallHistoryRow status updates [b#006]

2 participants