Skip to content

Add benchmark harness for whitelist [b#099] - #978

Merged
greatest0fallt1me merged 3 commits into
CalloraOrg:mainfrom
Jerry-Tekh:feat/whitelist-benchmark-924
Jul 29, 2026
Merged

Add benchmark harness for whitelist [b#099]#978
greatest0fallt1me merged 3 commits into
CalloraOrg:mainfrom
Jerry-Tekh:feat/whitelist-benchmark-924

Conversation

@Jerry-Tekh

Copy link
Copy Markdown
Contributor

Summary

  • benchmark the real CalloraWhitelist hot entrypoints with 32-address fixtures
  • isolate state-changing samples with Criterion batched setup so each invocation succeeds
  • replace stale vault-based whitelist tests with deterministic state-machine and auth coverage
  • remove the unrelated vault dev-dependency and document benchmark usage/baselines
  • fix redundant mutation authorization and stale whitelist compile/test errors exposed by the harness

Validation

  • cargo test -p callora-whitelist (24 unit tests and 5 integration tests passed)
  • cargo clippy -p callora-whitelist --all-targets --all-features -- -D warnings
  • cargo bench -p callora-whitelist -- --test (all 7 targets passed)
  • focused Rust formatting checks and git diff --check

Exact coverage percentage was not collected locally because no coverage runner is installed.

Closes #924

@drips-wave

drips-wave Bot commented Jul 28, 2026

Copy link
Copy Markdown

@Jerry-Tekh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Jerry-Tekh

Copy link
Copy Markdown
Contributor Author

CI status note (July 28, 2026):

All five failing checks stop before compiling or testing this PR's whitelist changes. They fail while Cargo parses the root workspace with:

contracts/emergency is listed in default-members but is not a member

This configuration is present in base commit 4e1438f, and the CI, coverage, and WASM-size workflows are also failing on main.

I tested the minimal workspace-membership correction locally. It gets past Cargo metadata, but the next workspace-wide formatting step exposes extensive pre-existing formatting drift across unrelated contracts. I have not included that repository-wide cleanup in this focused benchmark PR.

The whitelist package itself passes:

  • cargo test -p callora-whitelist
  • cargo clippy -p callora-whitelist --all-targets --all-features -- -D warnings
  • cargo bench -p callora-whitelist -- --test

@greatest0fallt1me
greatest0fallt1me merged commit 6dfd95c into CalloraOrg:main Jul 29, 2026
6 checks passed
@greatest0fallt1me

Copy link
Copy Markdown
Contributor

CI passed, solid PR — merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add benchmark harness for whitelist [b#099]

2 participants