feat: implement issues #913, #899, #830, #828 - #971
Open
chinecherem58 wants to merge 1 commit into
Open
Conversation
…CalloraOrg#828 CalloraOrg#913 – Add per-entrypoint gas snapshot tests for callora-topics - New contract: contracts/topics (src/lib.rs, errors.rs, events.rs) - contracts/topics/tests/gas_snap.rs: 11 gas snapshot tests covering init, register_topic, deactivate, get_topic, is_active, topic_count, get_admin, relative-growth, and boundary checks - ProfileSnapshot helper captures CPU + mem via env.cost_estimate() - JSON lines emitted for gas-regression.sh harvesting CalloraOrg#899 – Add cross-contract call safety tests for callora-upgrade - contracts/upgrade/tests/xcontract.rs: 7 tests covering happy-path recording, CooldownNotElapsed revert, Overflow revert, panic rollback, cooldown durability, and two sequential upgrades - Renamed overlong fn names to fit Soroban 32-char limit - contracts/upgrade/tests/err_stab.rs: fixed import paths to use callora_upgrade::admin::{UpgradeError, DEFAULT_COOLDOWN_SECONDS} CalloraOrg#830 – Add TTL bump on batch_claim storage reads - New contract: contracts/batch_claim (src/lib.rs, errors.rs, events.rs) - Every hot read path (get_claim, has_claim, batch_claim, cancel_claim) calls extend_ttl(PERSISTENT_THRESHOLD, PERSISTENT_BUMP) before reading persistent storage to prevent archival pressure - 17 unit tests including 3 dedicated TTL-bump idempotency tests CalloraOrg#828 – Per-entrypoint auth snapshot tests for revenue_pool - contracts/revenue_pool/tests/auth_snap.rs already contains 33 passing auth snapshot tests covering all mutating and read-only entrypoints; verified passing Workspace Cargo.toml: deduplicated members, added contracts/topics and contracts/batch_claim as new members. All 72 tests pass. cargo fmt and clippy --deny warnings clean. Closes CalloraOrg#913 Closes CalloraOrg#899 Closes CalloraOrg#830 Closes CalloraOrg#828
|
@chinecherem58 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#913 – Add per-entrypoint gas snapshot tests for callora-topics
#899 – Add cross-contract call safety tests for callora-upgrade
#830 – Add TTL bump on batch_claim storage reads
#828 – Per-entrypoint auth snapshot tests for revenue_pool
Workspace Cargo.toml: deduplicated members, added contracts/topics and contracts/batch_claim as new members.
All 72 tests pass. cargo fmt and clippy --deny warnings clean.
Closes #913
Closes #899
Closes #830
Closes #828