Skip to content

close issue #631 #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greatest0fallt1me merged 1 commit into from
Jul 28, 2026
+22 −37
Merged

close issue #631 #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 22 additions & 37 deletions src/workers/slowQueryAlerter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { resetAllMetrics, register } from '../metrics.js';
import { logger } from '../logger.js';
import type { Pool } from 'pg';
import {
createSlowQueryAlerterJob,
Expand Down Expand Up @@ -30,9 +31,13 @@ describe('slowQueryAlerter', () => {

beforeEach(() => {
originalFetch = global.fetch;
jest.spyOn(console, 'log').mockImplementation(() => {});
jest.spyOn(console, 'warn').mockImplementation(() => {});
jest.spyOn(console, 'error').mockImplementation(() => {});
// `logger` wraps `console.*` at module load time (see logger.ts), so
// spying on `console.*` here would never intercept calls made through
// `logger`. Spy on `logger` directly instead, matching the convention
// used in sloAlertRecorder.test.ts.
jest.spyOn(logger, 'info').mockImplementation(() => undefined);
jest.spyOn(logger, 'warn').mockImplementation(() => undefined);
jest.spyOn(logger, 'error').mockImplementation(() => undefined);
});

afterEach(() => {
Expand Down Expand Up @@ -177,9 +182,7 @@ describe('slowQueryAlerter', () => {
});

job.start();
await Promise.resolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

expect(mockPool.query).toHaveBeenCalledWith(
expect.stringContaining('pg_stat_statements'),
Expand Down Expand Up @@ -216,17 +219,13 @@ describe('slowQueryAlerter', () => {
});

job.start();
await Promise.resolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

expect(fetchMock).toHaveBeenCalledTimes(1);
fetchMock.mockClear();

jest.advanceTimersByTime(300_000);
await Promise.resolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

expect(fetchMock).not.toHaveBeenCalled();

Expand All @@ -251,18 +250,14 @@ describe('slowQueryAlerter', () => {
});

job.start();
await Promise.resolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

expect(fetchMock).toHaveBeenCalledTimes(1);
fetchMock.mockClear();
(mockPool.query as jest.Mock).mockClear();

jest.advanceTimersByTime(200);
await Promise.resolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

expect(fetchMock).toHaveBeenCalledTimes(1);
job.stop();
Expand Down Expand Up @@ -302,12 +297,10 @@ describe('slowQueryAlerter', () => {
expect(mockPool.query).toHaveBeenCalledTimes(1);

queryResolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

jest.advanceTimersByTime(10);
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

expect(mockPool.query).toHaveBeenCalledTimes(2);

Expand Down Expand Up @@ -399,9 +392,7 @@ describe('slowQueryAlerter', () => {
});

job.start();
await Promise.resolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

const metrics = await register.getMetricsAsJSON();
const runsMetric = metrics.find(
Expand Down Expand Up @@ -447,11 +438,9 @@ describe('slowQueryAlerter', () => {
});

job.start();
await Promise.resolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

expect(console.error).toHaveBeenCalledWith(
expect(logger.error).toHaveBeenCalledWith(
expect.stringContaining('[slowQueryAlerter] Webhook returned 500'),
'Internal Server Error',
);
Expand All @@ -477,11 +466,9 @@ describe('slowQueryAlerter', () => {
});

job.start();
await Promise.resolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

expect(console.error).toHaveBeenCalledWith(
expect(logger.error).toHaveBeenCalledWith(
expect.stringContaining('[slowQueryAlerter] Webhook post failed:'),
'network error',
);
Expand All @@ -502,11 +489,9 @@ describe('slowQueryAlerter', () => {
});

job.start();
await Promise.resolve();
await Promise.resolve();
await Promise.resolve();
await job.awaitIdle();

expect(console.error).toHaveBeenCalledWith(
expect(logger.error).toHaveBeenCalledWith(
expect.stringContaining('[slowQueryAlerter] Job failed:'),
expect.any(Error),
);
Expand Down