test: Add integration tests for ETag caching on /api/apis - #1049
Merged
greatest0fallt1me merged 1 commit intoJul 29, 2026
Merged
Conversation
|
@Immaculate0606 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
LGTM — clean diff and clear commits. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Closes #735
Description
This PR verifies the implementation of strong ETag and
304 Not Modifiedcaching mechanisms on the public API endpoints (GET /api/apisandGET /api/apis/:id), cutting down bandwidth overhead on repeat reads.The
etagMiddlewarelogic is already integrated correctly into the route handlers; this PR finalizes the implementation by guaranteeing end-to-end coverage for the specified behaviors.Changes
tests/integration/apis.test.ts):/api/apis: Asserts that an initial request generates a 200 OK along with a strong SHA-256 ETag. Submitting this same ETag in anIf-None-Matchheader on subsequent requests now asserts that a304 Not Modifiedis correctly intercepted and returned without a body./api/apis/:id: Adds equivalent assertions for the detailed view endpoint, confirming that specific API entity reads also support strong caching validations and appropriately bypass the body payload on cache hits.200 OKresponse.Testing Instructions
npm run test -- tests/integration/apis.test.tsto execute the integration suite.ETag Cachingsub-tests pass successfully.