Feature/issue 738 proxy test - #1048
Merged
greatest0fallt1me merged 2 commits intoJul 29, 2026
Merged
Conversation
|
@Immaculate0606 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Nice work, everything checks out. Merged 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Closes #738
Description
This PR upgrades the
tests/integration/proxy.test.tssuite to utilize a real PostgreSQL database viatestcontainers, enabling end-to-end testing of the proxy'sidempotencyMiddlewarewhich previously skipped its assertions when a database connection was unavailable.Changes
GenericContainer('postgres:16-alpine')configuration within thebeforeAllblock to spin up a fully isolated PostgreSQL container on a dynamic port during testing.runAllMigrationshelper to dynamically apply all.sqlschema definitions from themigrations/directory to the test container before any requests are handled.buildProxyApptest harness to accept the actualPoolinstance from thetestcontainerscontext and properly bind it toapp.locals.dbPool, ensuring the idempotency layer hooks into the container instead of failing.PG may be unavailablebypass in the idempotency POST test. It now strictly validates thatIdempotency-Keycorrectly deduplicates matching requests and serves the cached response accurately.Testing Instructions
npm test tests/integration/proxy.test.tslocally with a running Docker daemon.